Skip to content

hal_nxp: Removed MKV56F24.h wrong macro FLEXCAN2 #93489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nxp-wei-feng
Copy link

@nxp-wei-feng nxp-wei-feng commented Jul 22, 2025

Fixes #93129

Copy link

Hello @nxp-wei-feng, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Jul 22, 2025
Copy link

github-actions bot commented Jul 22, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@7a52cbb (master) zephyrproject-rtos/hal_nxp#580 zephyrproject-rtos/hal_nxp#580/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 22, 2025
@lucien-nxp
Copy link
Contributor

Hi @dleach02 @decsny @butok
Could you help add reviewers for this PR and hal_nxp PR? Thank you.

@mmahadevan108
Copy link
Contributor

@nxp-wei-feng Please take a look at the guidelines for Commit messages:
https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines
This should help address the compliance failure error.

Update SHA in west.yml to get fixed MKV56F24.h in hal_nxp

Signed-off-by: Feng Wei <wei.feng@nxp.com>
@nxp-wei-feng nxp-wei-feng force-pushed the hal_nxp_fix_kv56_header branch from cbfe707 to a15347e Compare July 23, 2025 04:17
Copy link

@nxp-wei-feng
Copy link
Author

@dleach02 @mmahadevan108 do you know why the check failed? The files with license issue is irrelevant with my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NXP HAL] MKV56F24 header incorrectly defines FLEXCAN2, causing FlexCAN build failure
6 participants