Skip to content

dts: arm: silabs: instantiate acmp1 nodes for xg2x parts #93452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silabs-BastienB
Copy link
Contributor

@silabs-BastienB silabs-BastienB commented Jul 21, 2025

The goal of this PR is to instantiate the missing instance acmp1 for xg21, xg23 and xg24 devices and fix the interrupt priority for acmp0. acmp1 can be used with the comparator driver.

@zephyrbot zephyrbot added the platform: Silabs Silicon Labs label Jul 21, 2025
@silabs-BastienB silabs-BastienB force-pushed the dts/arm/silabs/add-acmp1 branch 2 times, most recently from 9f42021 to 8d01ec3 Compare July 21, 2025 17:02
Copy link
Contributor

@Martinhoff-maker Martinhoff-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the bus address change for xg21, LGTM.
Don't forget to rebase your work to get rid of the CI problem.

Add the missing node for acmp1 in the dts for xg21, xg23 and xg23 devices.

Signed-off-by: Bastien Beauchamp <bastien.beauchamp@silabs.com>
Fix interrupt level for acmp0 in the dts for xg21 device.
Only radio interrupts are critical and should have priority 0.

Signed-off-by: Bastien Beauchamp <bastien.beauchamp@silabs.com>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Silabs Silicon Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants