Bluetooth: Mesh: Blob Server considers friendship #93335
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
3 times, most recently
from
8129cdd to
221a3b0
Compare
|
Hi @omkar3141, this change is ok to me to provide aligned to the friend queue size information. It makes our server smarter. |
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
from
221a3b0 to
de71cc5
Compare
zephyrbot
requested review from
akredalen,
Andrewpini,
HaavardRei,
jhedberg,
LingaoM and
PavelVPV
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
from
de71cc5 to
b84805a
Compare
alxelax
reviewed
Jul 21, 2025
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
from
b84805a to
1ae6640
Compare
HaavardRei
reviewed
Jul 22, 2025
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
from
1ae6640 to
3c6876e
Compare
alxelax
previously approved these changes
Jul 22, 2025
HaavardRei
previously approved these changes
Jul 22, 2025
PavelVPV
reviewed
Jul 24, 2025
Fix Max Chunk reporting during Block_Information_Get:
If friendship is established, then max possible chunk size for transfer
is reported according to friend's queue size.
ChunkSize = (FndQ sz * Bytes per seg (12)) - Opcode(1) - Chunk_Num (2)-
8 byte MIC (max)
= (FndQ sz * 12) - 11
This allows all segments of Chunk_Transfer messages to fit in a friend
queue. If this is not done, friend queue keeps overflowing
systematically causing unstable PULL_MODE transfers.
Fix Chunk requests:
Adapt number of requested chunks according to current friend queue size.
If friend queue is too small, at least 1 chunk is requested.
Signed-off-by: Omkar Kulkarni <omkar.kulkarni@nordicsemi.no>
omkar3141
force-pushed
the
omka/NCSDK-34138_blob_server_understands_lpn
branch
from
3c6876e to
5692977
Compare
alxelax
approved these changes
Jul 25, 2025
PavelVPV
approved these changes
Jul 25, 2025
HaavardRei
approved these changes
Jul 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Max Chunk reporting during Block_Information_Get:
If friendship is established, then max possible chunk size for transfer
is reported according to friend's queue size.
ChunkSize = (FndQ sz * Bytes per seg (12)) - Opcode(1) - Chunk_Num (2)-
8 byte MIC (max)
= (FndQ sz * 12) - 11
This allows all segments of Chunk_Transfer messages to fit in a friend
queue. If this is not done, friend queue keeps overflowing
systematically causing unstable PULL_MODE transfers.
Fix Chunk requests:
Adapt number of requested chunks according to current friend queue size.
If friend queue is too small, at least 1 chunk is requested.