Skip to content

drivers: mdio: shell: Fix argument count #93257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: mdio: shell: Fix argument count #93257

wants to merge 1 commit into from
+13 −8

Conversation

clamattia
Copy link
Contributor

@clamattia clamattia commented Jul 17, 2025 •
edited
Loading

Need to have correct argument count to avoid crash.

Fixes: #93254

@clamattia clamattia requested a review from maass-hamburg July 17, 2025 08:23
@zephyrbot zephyrbot requested a review from decsny July 17, 2025 08:23
@clamattia clamattia mentioned this pull request Jul 17, 2025
Merged
@clamattia
Copy link
Contributor Author

Related: #93254

@clamattia clamattia force-pushed the hotfix/mdio_shell_buffer_overflow branch from 839b05b to 9f97e96 Compare July 17, 2025 08:27
@clamattia clamattia force-pushed the hotfix/mdio_shell_buffer_overflow branch from 9f97e96 to 1b4dd13 Compare July 17, 2025 08:42
etienne-lms
etienne-lms previously approved these changes Jul 17, 2025
View reviewed changes
tpambor
tpambor reviewed Jul 17, 2025
View reviewed changes
drivers/mdio/mdio_shell.c Outdated
if (ret < 0) {
return ret;
}

if (argc < 5) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and the below new checks are not needed as the commands take no optional arguments and therefore this is already checked by the shell.

zephyr/include/zephyr/shell/shell.h

Lines 531 to 532 in 72dc0e5

* @note If a command will be called with wrong number of arguments shell will
* print an error message and command handler will not be called.

tpambor
tpambor reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@tpambor tpambor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the number of mandatory arguments for the scan command should be fixed, currently 1 but should be 2, scan and device.

	SHELL_CMD_ARG(scan, &dsub_device_name,
		"Scan MDIO bus for devices: scan <device> [<reg_addr>]",
		cmd_mdio_scan, 1, 1),

@clamattia
drivers: mdio: shell: Fix argument count
30e1d6f 
Need to have correct argument count to avoid crash.

Signed-off-by: Cla Mattia Galliard <cla-mattia.galliard@zuehlke.com>
@clamattia clamattia force-pushed the hotfix/mdio_shell_buffer_overflow branch from 1b4dd13 to 30e1d6f Compare July 24, 2025 11:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@clamattia clamattia mentioned this pull request Jul 24, 2025
Open
@clamattia
Copy link
Contributor Author

Fixed according to @tpambor suggestion
Rebased

@clamattia clamattia requested review from tpambor and etienne-lms July 24, 2025 11:49
@clamattia clamattia changed the title drivers: mdio: shell: Fix various buffer overflows drivers: mdio: shell: Fix argument count Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpambor tpambor tpambor approved these changes

@maass-hamburg maass-hamburg maass-hamburg approved these changes

@decsny decsny Awaiting requested review from decsny

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@jukkar jukkar Awaiting requested review from jukkar

@lmajewski lmajewski Awaiting requested review from lmajewski

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@pdgendt pdgendt Awaiting requested review from pdgendt

@rlubos rlubos Awaiting requested review from rlubos

@ssharks ssharks Awaiting requested review from ssharks

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

At least 2 approving reviews are required to merge this pull request.

Assignees

@maass-hamburg maass-hamburg

Labels
area: Ethernet area: MDIO area: Networking platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ethernet: mdio: Shell Usability: list devices on error
5 participants
@clamattia @tpambor @etienne-lms @maass-hamburg @zephyrbot