drivers: wifi: siwx91x: Add support for link mode query #93253
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
zephyrbot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
muahmed-silabs
force-pushed
the
add/wifi-status-link-mode
branch
from
42ad42c to
6bcf398
Compare
| @@ -73,7 +73,7 @@ int siwx91x_status(const struct device *dev, struct wifi_iface_status *status) | |||
| if (FIELD_GET(SIWX91X_INTERFACE_MASK, interface) == SL_WIFI_CLIENT_INTERFACE) { | |||
| sl_wifi_operational_statistics_t operational_statistics = { }; | |||
|
|
|||
| status->link_mode = WIFI_LINK_MODE_UNKNOWN; | |||
| status->link_mode = wlan_info.wireless_mode; | |||
There was a problem hiding this comment.
Don't you need to convert the value? If by chance the values used by Wiseconnect and by Zephyr are the same, you need to mention that in a comment.
There was a problem hiding this comment.
Yes, the values are the same. I'll add a comment.
Also, should it be explicitly typecasted?
Mapped the link mode (wireless mode) from wireless info to the wifi status API. Signed-off-by: Muzaffar Ahmed <muzaffar.ahmed@silabs.com>
muahmed-silabs
force-pushed
the
add/wifi-status-link-mode
branch
from
6bcf398 to
20f38ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapped the link mode (wireless mode) from wireless info to the wifi status API.