Feature/impl a2dp get all cap #93175
Open
+320
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth Classic
MarkWangChinese
force-pushed
the
feature/impl_a2dp_get_all_cap
branch
from
65cd040 to
cffd7ea
Compare
MarkWangChinese
force-pushed
the
feature/impl_a2dp_get_all_cap
branch
from
cffd7ea to
2fcb45e
Compare
lylezhu2012
reviewed
Jul 22, 2025
| @@ -798,7 +811,7 @@ SHELL_STATIC_SUBCMD_SET_CREATE(a2dp_cmds, | |||
| cmd_register_ep, 3, 0), | |||
| SHELL_CMD_ARG(connect, NULL, HELP_NONE, cmd_connect, 1, 0), | |||
| SHELL_CMD_ARG(disconnect, NULL, HELP_NONE, cmd_disconnect, 1, 0), | |||
| SHELL_CMD_ARG(discover_peer_eps, NULL, HELP_NONE, cmd_get_peer_eps, 1, 0), | |||
| SHELL_CMD_ARG(discover_peer_eps, NULL, "<avdtp version value>", cmd_get_peer_eps, 1, 1), | |||
There was a problem hiding this comment.
Suggested change
| SHELL_CMD_ARG(discover_peer_eps, NULL, "<avdtp version value>", cmd_get_peer_eps, 1, 1), | |
| SHELL_CMD_ARG(discover_peer_eps, NULL, "[avdtp version value]", cmd_get_peer_eps, 1, 1), |
| BT_SDP_PROTO_L2CAP = 0x0100, | ||
| BT_SDP_PROTO_AVDTP = 0x0019, |
There was a problem hiding this comment.
Suggested change
| BT_SDP_PROTO_L2CAP = 0x0100, | |
| BT_SDP_PROTO_AVDTP = 0x0019, | |
| BT_SDP_PROTO_AVDTP = 0x0019, | |
| BT_SDP_PROTO_L2CAP = 0x0100, |
get the avdtp version through the bt_sdp_get_proto_param Signed-off-by: Mark Wang <yichang.wang@nxp.com>
From avdtp spec, the get_all_capablities should be used if the avdtp version is v1.3, otherwise the get_capabilities should be used. Signed-off-by: Mark Wang <yichang.wang@nxp.com>
MarkWangChinese
force-pushed
the
feature/impl_a2dp_get_all_cap
branch
from
2fcb45e to
3ff0a40
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the avdtp/a2dp get_all_capabilities cmd and rsp.
From avdtp spec, the get_all_capablities should be used if the avdtp version is v1.3, otherwise the get_capabilities should be used.
Improve sdp to get the avdtp version through the bt_sdp_get_proto_param.