-
Notifications
You must be signed in to change notification settings - Fork 7.7k
drivers: serial: native_tty: config_get support #93149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db5efa6
to
717c119
Compare
(Just for info) Related to #69101 |
Oh, didn't notice that. |
Thanks for the PR @vytvir. |
From @dcpleung comment:
This was my assumption too. I guess for the sake of completeness it's a nice-to-have, but not strictly neccecary? That said, I just wanted the u_blox m8 driver to run without error'ing out. So I'm fine with either option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vytvir just a few minor silly things.
Requested changes by @aescolar completed. |
This commit adds config_get support for native_tty. This is helpful as some driver code (e.g. u_blox m8) will error out if they can't read the current configuration. Signed-off-by: Vytautas Virvičius <vytautas@virvicius.dev>
|
int err = 0; | ||
|
||
err = errno; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int err = 0; | |
err = errno; | |
int err = errno; |
Just saw this now, but you don't need to bother with it if you don't need to push again
Hi @dcpleung , could you give this a review? |
This commit adds config_get support for native_tty. This is helpful as some driver code (e.g. u_blox m8) will error out if they can't read the current configuration.