-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: nrf_wifi: Fix TX rate in Mbps #93085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kapbh
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
kapbh:invalid_rate_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
previously approved these changes
Jul 14, 2025
rlubos
previously approved these changes
Jul 14, 2025
krish2718
reviewed
Jul 14, 2025
The Tx rate was previously stored as an integer, which caused loss of precision for rates like 8.6 Mbps or 34.4 Mbps due to integer division. The change will update data type to float. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
Update hostap revision to fix tx rate. Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
krish2718
approved these changes
Jul 15, 2025
rlubos
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Networking
area: Wi-Fi
Wi-Fi
DNM (manifest)
This PR should not be merged (controlled by action-manifest)
manifest
manifest-hostap
size: XS
A PR changing only a single line of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current_tx_rate will be in Kbps. It is showing wrong TX rate in wifi status. Need to convert tx_birate to Kbps.