Enable rtc on rt700 #93006
Open
Enable rtc on rt700 #93006
+191
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
bjarki-andreasen,
butok,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
kartben,
manuargue,
mmahadevan108,
nashif and
Raymond0225
Holt-Sun
force-pushed
the
enable-rtc-on-rt700
branch
from
c1b3d9c to
55a2226
Compare
bjarki-andreasen
requested changes
Jul 11, 2025
samples/drivers/rtc/src/main.c
Outdated
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| const struct device *const rtc = DEVICE_DT_GET(DT_ALIAS(rtc)); | |||
|
|
|||
| #if !(DT_PROP(DT_ALIAS(rtc), share_counter)) | |||
There was a problem hiding this comment.
this can not go in a common sample, board/soc specific logic stays with the board/soc, if really needed, in a board specific sample in samples/boards/nxp/ :)
There was a problem hiding this comment.
Updated. Move the #if (DT_PROP(DT_ALIAS(rtc), share_counter)) into rtc_nxp_irtc.c nxp_irtc_set_time function. Please review.
dts/bindings/rtc/nxp,irtc.yaml
Outdated
Comment on lines
43
to
47
| share-counter: | ||
| type: boolean | ||
| description: | | ||
| This slave irtc instance shares the data and time counters of the master irtc instance. | ||
| This means the code cannot set the data and time counters, but can only read them. |
There was a problem hiding this comment.
This property should be enforced on the driver level, by implementing the set_time API like
static int set_time_not_perm(const struct device *dev, const struct rtc_time *timeptr)
{
ARG_UNUSED(timeptr);
return -EPERM;
}
static DEVICE_API(...) = {
.set_time = set_time_not_perm,
...
};
the sample does not need to be updated, it will correclty print "Cannot write date time: -1"
1. Update nxp irtc driver to fix issue in init and alarm function. 2. Update RTC device tree binding to support "share-counter". 3. Update RT700 dtsi to support rtc0 for cpu0 and rtc1 for cpu1. 4. Update readme. Signed-off-by: Holt.Sun <holt.sun@nxp.com>
1. Update overlay and project conf for RT700. 2. Update test_alarm.c to disable RTC irq so that callback function won't be called to clear the pending interrupt. Signed-off-by: Holt.Sun <holt.sun@nxp.com>
Holt-Sun
force-pushed
the
enable-rtc-on-rt700
branch
from
55a2226 to
620191f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rtc driver to support NXP RT700.
Enable rt700 RTC unittest.