Update esptool v5 as an package #92894
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with PR revision and 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_espressif
DNM (manifest)
There was a problem hiding this comment.
I thought you said you were going to add this dependency in the hal_espressif module?
Something like https://github.com/zephyrproject-rtos/nanopb/blob/master/zephyr/module.yml#L5-L8
scripts/requirements-actions.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # This file was autogenerated by uv via the following command: | |||
| # uv pip compile --universal --python-version 3.10 --generate-hashes requirements-actions.in --output-file requirements-actions.txt | |||
There was a problem hiding this comment.
If you were to keep this approach (which I don't think you should) thien this file should be refreshed by running the exact same command (i.e targeting python 3.10)
There was a problem hiding this comment.
Ok, will fix it. If we wont provide the esptool as a package we will be force to use it like PYTHONPATH=/path/to/hal/espressif/tools/ python -m esptool instead of esptool. If you see the other options please comment.
|
The current esptool-5.0.0 has a bug that affects some Zephyr builds; therefore, we need to wait for the fix, which will be released as |
Brings changes in how esptool is istalled in the environment. Signed-off-by: Marek Matej <marek.matej@espressif.com>
marekmatej
force-pushed
the
feature/esptool_v5_package
branch
from
fd71d8c to
e49e04c
Compare
Updated requirements-actions.in,txt to fetch esptool for the CI. Fix format of the arguments used in the esptool-5.0.0. TODO: esptool>=5.0.1 is required, which was not yet released Signed-off-by: Marek Matej <marek.matej@espressif.com>
marekmatej
force-pushed
the
feature/esptool_v5_package
branch
from
e49e04c to
f86d481
Compare
|
This PR brings the changes in how the esptool is installed in the system. Instead of hard-copy in the hal/espressif, it put the esptool on the list of required packages. This reflects the new esptool v5.0.0, which comes with several breaking changes.