include: zephyr: dt-bindings: Fix USB_SEL mask #92876
Conversation
github-actions
bot
added
size: XS
|
I also needed the MCO feature to make the USB work, and I noticed the mask was not correct for it. Would it be desirable also to add a new header file like this? Perhaps I should squash these changes into one commit? |
There was a problem hiding this comment.
Nitpicking and non-blocking: could you fix the RefMan reference in the commit message body
(for commit "include: zephyr: dt-bindings: Fix MCOx_yyy masks"): it's RM0490 instead of RM490?
Also it would be nice to give the manual revision number (currently "Rev 5") in case a new revision comes and section or page numbering changes. (Would apply to both commits).
Selecting the clock source for USB is only a bit value in the CCIPR2 register. See RM0490 Rev 5 chapter 6.4.21 page 159. Signed-off-by: Tomáš Juřena <jurenatomas@gmail.com>
Macros MCO1_SEL, MCO1_PRE, MCO2_SEL, MCO2_PRE uses 4 bits wide masks as defined in the RM0490 Rev 5 section 6.4.3, page 136 Signed-off-by: Tomáš Juřena <jurenatomas@gmail.com>
jurenat
force-pushed
the
fix-stm32c071-usb_sel-mask
branch
from
ee9302f to
2bf7744
Compare
|
I think your 2 commits are perfect as they are. |
danieldegrasse
added
the
backport-v4.2-branch
Selecting the clock source for USB is only a bit value in the CCIPR2 register.
See RM0490 chapter 6.4.21 page 159.