usb: device_next: allow to pass maximum possible MPS value to drivers #92831
+160
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper function to enable/disable control endpoint. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
The wMaxPacketSize (MPS) value of an endpoint may vary depending on the interface's alternate settings. Device controller, which uses dedicated memory for the endpoint FIFO, may end up in a locked state during endpoint reconfiguration if the allocated memory is too small but the higher memory window is still used. Although the driver could allocate a new, larger memory window, the last used window would likely remain unused, wasting a bit of dedicated RAM. Allow the stack to pass the maximum possible MPS value within alternate settings. For a controller with endpoint FIFOs and dedicated RAM, the driver should use this value for the FIFO configuration. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
To ensure that the alternate endpoint setting does not result in a memory window that is too small being allocated and locked because a higher FIFO is still in use, use the maximum MPS value for FIFO memory allocation. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
jfischer-no
added
area: USB
github-actions
bot
added
platform: STM32
github-actions
bot
requested review from
aaronyegx,
AlessandroLuo,
Dino-Li,
erwango,
fabiobaltieri,
FRASTM,
GTLin08,
jackrosenthal,
keith-zephyr,
MarkWangChinese,
mmahadevan108,
RichardSWheatley and
RuibinChang
|
fabiobaltieri
approved these changes
Jul 8, 2025
| * | ||
| * @return 0 on success, all other values should be treated as error. | ||
| * @retval -ENODEV endpoint is not assigned or no configuration found | ||
| * @retval -EALREADY endpoint is already enabled |
There was a problem hiding this comment.
This -EALRADY description seems wrong. It is disable function.
tmon-nordic
reviewed
Jul 9, 2025
| err1 = udc_ep_disable_internal(dev, USB_CONTROL_EP_IN); | ||
| err2 = udc_ep_disable_internal(dev, USB_CONTROL_EP_OUT); | ||
|
|
||
| return err1 ? err1 : err2; |
There was a problem hiding this comment.
This modifies the sequence that is performed on endpoint disable. Now the disable function will be called on both IN and OUT (before it was called first on OUT and then on IN) regardless of the returned error. Before first OUT endpoint was disabled and then IN endpoint was disabled only if OUT endpoint disable succeeded.
| * | ||
| * @return 0 on success, all other values should be treated as error. | ||
| * @retval -ENODEV endpoint is not assigned or no configuration found | ||
| * @retval -EALREADY endpoint is already enabled |
There was a problem hiding this comment.
Looks like copy&paste error, if endpoint is "already enabled" then disable should succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the stack to pass the maximum possible MPS value within alternate
settings.