Silabs gpio driver #92824

fimohame · 2025-07-08T09:08:07Z

The commit enables the gpio driver for EFR series 2 devices.

drivers/gpio/gpio_silabs.c

dts/arm/silabs/xg24/xg24.dtsi

Martinhoff-maker

I haven't gone through all the gpio_silabs.c files but in general:

We need to only use sl_hal_gpio functions. sl_gpio.h is already a driver in the HAL and it initializes things like clocks which we want to handle in the Zephyr driver.
We also need to have a new Kconfig symbol in zephyr/modules/hal_silabs/simplicity_sdk like "SILABS_SISDK_GPIO" and make changes to CMakeLists.txt accordingly. You can take inspiration from #92010
We should update the dtsi files for all Series 2 boards with this new GPIO driver and create an entry in the migration guide 4.3.
Don't forget to add a binding file for the driver.

drivers/gpio/Kconfig.silabs

dts/arm/silabs/xg24/xg24.dtsi

drivers/gpio/Kconfig.silabs

drivers/gpio/gpio_silabs.c

Martinhoff-maker

As general comment, as done in gpio_silabs_siwx91x.c, it could be good to have clear device name in general : is it the parent device ( the gpio controller) or the port device rather ? than just having "dev" names everywhere.

Adding PM would be perfect also (might be part of another PR)

Martinhoff-maker · 2025-07-21T09:34:12Z

dts/arm/silabs/xg21/xg21.dtsi

@@ -347,7 +347,7 @@
 			#size-cells = <1>;

 			gpioa: gpio@5003c000 {
-				compatible = "silabs,gecko-gpio-port";
+				compatible = "silabs,gecko-gpio-port","silabs,gpio-port";


It can become the fist one compatible driver

Martinhoff-maker · 2025-07-21T09:35:25Z

modules/hal_silabs/simplicity_sdk/CMakeLists.txt

+endif()
+
+if(CONFIG_SILABS_SISDK_GPIO)
+  zephyr_library_sources(
    ${DRIVER_DIR}/gpio/src/sl_gpio.c


is it still needed ?

Martinhoff-maker · 2025-07-21T11:55:07Z

drivers/gpio/gpio_silabs.c

+			 PRE_KERNEL_1, CONFIG_GPIO_SILABS_COMMON_INIT_PRIORITY,                    \
+			 &gpio_silabs_common_driver_api);
+
+GPIO_CONTROLLER_INIT(0)


it feels not right to have this hardcoded value, we need to rely on device tree node. Have you tried to modify it in order to have the same logic as gpio_silabs_siwx91x.c ? Something like:

#define GPIO_CONTROLLER_INIT(idx) \ ........... \ DEVICE_DT_INST_DEFINE(..............); \ DT_INST_FOREACH_CHILD_STATUS_OKAY(idx, GPIO_PORT_INIT); DT_INST_FOREACH_STATUS_OKAY(GPIO_CONTROLLER_INIT)

Martinhoff-maker · 2025-07-21T11:56:29Z

drivers/gpio/gpio_silabs.c

+	}
+}
+
+static const struct gpio_driver_api gpio_silabs_port_driver_api = {


you should use static DEVICE_API

Martinhoff-maker · 2025-07-21T11:56:49Z

drivers/gpio/gpio_silabs.c

+	.manage_callback = gpio_silabs_port_manage_callback,
+};
+
+static const struct gpio_driver_api gpio_silabs_common_driver_api = {


same comment as above

Martinhoff-maker · 2025-07-21T14:37:36Z

drivers/gpio/gpio_silabs.c

+	return 0;
+}
+
+static int gpio_silabs_port_toggle_bits(const struct device *dev, uint32_t mask)


We should use "gpio_port_pins_t" instead of uint32_t as described in "gpio.h"
Same comment for all the other function that use the mask"

Martinhoff-maker · 2025-07-21T15:12:17Z

drivers/gpio/gpio_silabs.c

+#error GPIO_SILABS_COMMON_INIT_PRIORITY must be less than CONFIG_GPIO_INIT_PRIORITY
+#endif
+
+#if DT_NODE_HAS_PROP(id, peripheral_id)


can't we simplify this ? did we really used peripheral_id ? or should we make it mandatory ? (open question)

It's actually not required

Martinhoff-maker · 2025-07-22T13:09:03Z

modules/hal_silabs/simplicity_sdk/CMakeLists.txt

@@ -253,7 +253,15 @@ zephyr_library_sources_ifdef(CONFIG_SOC_GECKO_EMU          ${EMLIB_DIR}/src/em_e
 if(CONFIG_SOC_GECKO_GPIO)
  zephyr_library_sources(
    ${EMLIB_DIR}/src/em_gpio.c
-    ${DRIVER_DIR}/gpio/src/sl_gpio.c


I suggest to let this line for compatibility purpose until we removed all the SOC_GECKO symbol from SimplicitySDK CMakeLists

Martinhoff-maker · 2025-07-22T15:25:43Z

drivers/gpio/Kconfig.silabs

+
+menuconfig GPIO_SILABS
+	bool "Silabs GPIO driver"
+	default n


I just see it but normally it was set to "y" by default (look at other)

Added the gpio driver for EFR series 2 devices. Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>

Added the xg29_rb4412a.overlay xg29_rb4412a.conf configuration for GPIO API 1-pin, Basic api, Hogs test apps. This overlay and conf defines the configuration needed to validate the GPIO driver on the xg29_rb4412a board during test execution. Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>

sonarqubecloud · 2025-07-23T10:32:59Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fimohame closed this Jul 8, 2025

fimohame reopened this Jul 8, 2025

fimohame closed this Jul 8, 2025

fimohame reopened this Jul 8, 2025

fimohame closed this Jul 8, 2025

fimohame reopened this Jul 8, 2025

fimohame force-pushed the silabs_gpio_driver branch from 74b3e13 to eca5b4b Compare July 8, 2025 10:18

smalae suggested changes Jul 8, 2025

View reviewed changes

fimohame force-pushed the silabs_gpio_driver branch 3 times, most recently from 6c73c92 to e46e7bc Compare July 9, 2025 05:59

fimohame requested a review from smalae July 9, 2025 06:04

fimohame marked this pull request as ready for review July 10, 2025 08:05

github-actions bot added area: GPIO platform: Silabs Silicon Labs labels Jul 10, 2025

github-actions bot requested review from asmellby, henrikbrixandersen, jerome-pouiller, jhedberg, Martinhoff-maker and mnkp July 10, 2025 08:05

github-actions bot assigned jhedberg and asmellby Jul 10, 2025

Martinhoff-maker requested changes Jul 11, 2025

View reviewed changes

fimohame force-pushed the silabs_gpio_driver branch from e46e7bc to 165546d Compare July 16, 2025 13:45

fimohame requested a review from Martinhoff-maker July 16, 2025 14:04

fimohame force-pushed the silabs_gpio_driver branch from 165546d to aedd2cc Compare July 17, 2025 06:29

zephyrbot requested review from rettichschnidi and yonsch July 17, 2025 06:30

Martinhoff-maker reviewed Jul 21, 2025

View reviewed changes

fimohame force-pushed the silabs_gpio_driver branch from aedd2cc to 42e464b Compare July 22, 2025 12:55

fimohame requested a review from Martinhoff-maker July 22, 2025 13:01

Martinhoff-maker reviewed Jul 22, 2025

View reviewed changes

fimohame force-pushed the silabs_gpio_driver branch from 42e464b to 042d435 Compare July 22, 2025 15:08

Martinhoff-maker reviewed Jul 22, 2025

View reviewed changes

fimohame force-pushed the silabs_gpio_driver branch from 042d435 to e30d249 Compare July 23, 2025 09:21

fimohame added 2 commits July 23, 2025 15:35

drivers: gpio: silabs: gpio driver for EFR series 2 devices

66db115

Added the gpio driver for EFR series 2 devices. Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>

fimohame force-pushed the silabs_gpio_driver branch from e30d249 to 49ab315 Compare July 23, 2025 10:06

fimohame mentioned this pull request Jul 23, 2025

EFR series 2 devices Kconfig updates for gpio #93615

Draft

Silabs gpio driver #92824

Are you sure you want to change the base?

Silabs gpio driver #92824

Uh oh!

Conversation

fimohame commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martinhoff-maker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martinhoff-maker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 23, 2025

Quality Gate passed

Uh oh!

Uh oh!