-
Notifications
You must be signed in to change notification settings - Fork 7.6k
tests/lib/timespec_util: Skip two tests by now #92766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These two (sub)tests assume the system tick period divides evenly all time interval values being tested, but this is not the case in general, and when it is not, these tests fail. Let's skip these 2 tests by now so we can release without a broken CI, and do not block other development while the tests themselves are being fixed. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
|
@aescolar - another fix is ready (#92709) as mentioned in #92255 In fact that fixes a few new bugs as well. I could file issues for them if you like. |
Thanks @cfriedt . But I don't think that fix should go in at this point in the release cycle as it has significant changes and we are past rc2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#92709 will actually need to be merged anyway as it fixes additional issues.
I'll mark it a hotfix as well.
@cfriedt would you be so kind as to unblock this PR so we can merge it as a stop gap? |
These two (sub)tests assume the system tick period divides evenly all time interval values being tested, but this is not the case in general, and when it is not, these tests fail.
Let's skip these 2 tests by now so we can release without a broken CI, and do not block other development while the tests themselves are being fixed.
Note that this happens at least for the majority of Nordic devices, and as such these tests fail in Nordic simulation in CI.
Mitigates #92158