Skip to content

tests/lib/timespec_util: Skip two tests by now #92766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Jul 7, 2025

These two (sub)tests assume the system tick period divides evenly all time interval values being tested, but this is not the case in general, and when it is not, these tests fail.

Let's skip these 2 tests by now so we can release without a broken CI, and do not block other development while the tests themselves are being fixed.

Note that this happens at least for the majority of Nordic devices, and as such these tests fail in Nordic simulation in CI.

Mitigates #92158

These two (sub)tests assume the system tick period divides evenly all
time interval values being tested, but this is not the case in general,
and when it is not, these tests fail.

Let's skip these 2 tests by now so we can release without a broken
CI, and do not block other development while the tests themselves are
being fixed.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar added this to the v4.2.0 milestone Jul 7, 2025
@aescolar aescolar marked this pull request as ready for review July 7, 2025 08:38
Copy link

sonarqubecloud bot commented Jul 7, 2025

@aescolar aescolar added bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. labels Jul 7, 2025
@aescolar aescolar requested a review from cfriedt July 7, 2025 08:39
@aescolar
Copy link
Member Author

aescolar commented Jul 7, 2025

@cfriedt thanks for looking into #92158. After closing #92255 we are left without a practical alternative for 4.2 (as we are passed rc2). If you don't mind, let's disable these two tests by now, so we don't block other development until some other fix is ready.

@cfriedt
Copy link
Member

cfriedt commented Jul 7, 2025

@cfriedt thanks for looking into #92158. After closing #92255 we are left without a practical alternative for 4.2 (as we are passed rc2). If you don't mind, let's disable these two tests by now, so we don't block other development until some other fix is ready.

@aescolar - another fix is ready (#92709) as mentioned in #92255

In fact that fixes a few new bugs as well. I could file issues for them if you like.

@aescolar
Copy link
Member Author

aescolar commented Jul 7, 2025

@aescolar - another fix is ready (#92709) as mentioned in #93255

Thanks @cfriedt . But I don't think that fix should go in at this point in the release cycle as it has significant changes and we are past rc2.
Just disabling these 2 tests by now eliminates the urgency from this issue unblocking others, so it can be worked on calmly.

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#92709 will actually need to be merged anyway as it fixes additional issues.

I'll mark it a hotfix as well.

@aescolar
Copy link
Member Author

aescolar commented Jul 7, 2025

@cfriedt note this is just a stop gap to unblock other PRs and not have a failing CI. This commit can certainly be reverted as part of #92709.

@aescolar
Copy link
Member Author

aescolar commented Jul 8, 2025

@cfriedt would you be so kind as to unblock this PR so we can merge it as a stop gap?

@dkalowsk dkalowsk merged commit 8f09262 into zephyrproject-rtos:main Jul 8, 2025
32 checks passed
@aescolar aescolar deleted the 92158 branch July 8, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants