Add shield for Adafruit Featherwing 128x32 OLED #92751
Conversation
github-actions
bot
added
area: Shields
github-actions
bot
requested review from
avisconti,
erwango,
jfischer-no,
kartben and
nashif
boards/shields/adafruit_featherwing_128x32_OLED/boards/adafruit_feather_nrf52840.overlay
Outdated
Show resolved
Hide resolved
boards/shields/adafruit_featherwing_128x32_OLED/adafruit_featherwing_128x32_OLED.overlay
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Cabé <kartben@gmail.com>
replace INPUT_KEY_1/2/3 by INPUT_KEY_A/B/C remove spaces fix documentation Signed-off-by: Stefan Schmidt <kontakt@stefanschmidt-embedded.com>
stemschmidt
force-pushed
the
adafruitFeatherWingOLED
branch
from
df0da72 to
5f5fb66
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Hi @kartben, I screwed up the initial commit message. What is the best way to get this fixed? Shall I squash all commits and format the commit message correctly? |
Yeah even had you not screwed up the initial commit we'd have asked you to squash all your successive changes anyways :) Just squash everything into one commit and fixing the commit message should then be a formality :) |
|
@stemschmidt let me know if you need help with the squashing |
|
Hi @kartben, no thanks, I just need time. I want to follow the contribution guidelines this time :-) Will do it soon... |
This PR adds support for a Adafruit Featherwing 128x32 OLED shield