-
Notifications
You must be signed in to change notification settings - Fork 7.6k
samples: net: http_client: Update the sample to work out-of-the-box with the net-tools scripts #92640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rlubos
wants to merge
3
commits into
zephyrproject-rtos:main
Choose a base branch
from
rlubos:net/http-client-tls-adjustements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
samples: net: http_client: Update the sample to work out-of-the-box with the net-tools scripts #92640
rlubos
wants to merge
3
commits into
zephyrproject-rtos:main
from
rlubos:net/http-client-tls-adjustements
+65
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rlubos
commented
Jul 3, 2025
- Pull the latest fixes in the http(s)-server python scripts in net tools
- Update the TLS configuration in the sample
- Rework the sample to run a single TLS (TCP) session at a time. Apparently the simple HTTPs sever in python does not handle parallel TLS sessions.
Python HTTPS server counterpart for the sample now seems to enforce ECDHE key exchange, so enable it in the sample. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Apparently the simple python HTTPS server the sample is interfacing, cannot handle parallel TLS sessions (just one at a time), hence establishing both IPv4/6 connections before sending request doesn't work well, half of the requests are dropped. Therefore, modify the sample a little to run only one TLS (or TCP if no TLS is used) connection at a time. Additionally, add a log in case HTTP client request fails, as it could easily be overlooked if something went wrong. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
jukkar
previously approved these changes
Jul 3, 2025
Pull latest fixes for HTTP(s) server scripts. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
6c49975
to
d3aac78
Compare
Updated net-tools SHA |
|
jukkar
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: HTTP
HTTP client/server support
area: Networking
area: Samples
Samples
area: Sockets
Networking sockets
manifest
manifest-net-tools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.