Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some area, RTIO is used to increase performance at a slight extra cost in code size.
For video, it seems like a partial RTIO-like flow was already adopted by @loicpoulain in video APIs out of kernel primitives (the same week RTIO was introduced), so switching to RTIO actually reduces the amount of code in drivers and simplify the video APIs.
API functions removed as now available through RTIO APIs:
.enqueue
.dequeue
.flush
.set_signal
(the polling API)API function added:
.iodev_submit
The sample
main.c
did not go down in size. This initial PR adds a naive implementation that exposes all the RTIO internals directly, allowing discussion with the RTIO developers and Video developers and users about what wrappers to implement.Keeping the low-level exposed is also a good opportunity to allow application libraries to wrap video APIs in higher-level and efficient userspace APIs.