Skip to content

doc: drivers: display: add basic controller info #92409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

everedero
Copy link
Contributor

Add basic controller information (techno, resolution, color depth...) for display drivers.

MaureenHelm
MaureenHelm previously approved these changes Jul 1, 2025
VynDragon
VynDragon previously approved these changes Jul 1, 2025
MaureenHelm
MaureenHelm previously approved these changes Jul 2, 2025
@MaureenHelm MaureenHelm requested a review from kartben July 2, 2025 14:51
kartben
kartben previously approved these changes Jul 2, 2025
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically non-blocking but would be really nice if you could spare the time to switch to using title: :) Thanks for this!

Comment on lines 4 to 5
description: |
Frida Techshine Panel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might as well move all of these to be the title:, since you're here and cleaning this up nicely.

@everedero everedero dismissed stale reviews from kartben, MaureenHelm, and VynDragon via 31d9e63 July 2, 2025 15:55
@everedero everedero force-pushed the doc/display branch 2 times, most recently from 31d9e63 to 104dbe0 Compare July 2, 2025 16:01
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! A few inconsistencies spotted.

Comment on lines 4 to 8
title: Solomon SSD1306 display controller on MPI_DBI or SPI bus

description: |
The Solomon SSD1306 is a monochrome OLED controller
with a maximum 128x64 resolution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be referring to ssd1327

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasted from the wrong file, of course... BTW what happens if description is moved to titi,toto-common.yaml instead of copied between toto-i2c and toto-spi?

Comment on lines 4 to 5
description: |
ILI9488 320x480 display controller
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

Comment on lines 1 to 2
description: |
SSD1322 display controller
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title

Add basic controller information (techno, resolution, color depth...)
for display drivers.

Signed-off-by: Eve Redero <eve.redero@gmail.com>
Copy link

sonarqubecloud bot commented Jul 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Display platform: ADI Analog Devices, Inc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants