Skip to content

drivers: ethernet: nxp_enet: Fix PHY configure for fixed-link config #92400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ofirshe
Copy link
Contributor

@ofirshe ofirshe commented Jun 30, 2025

Update the driver to handle -ENOSYS from phy_configure_link(), which is now returned when the cfg_link callback is missing (e.g., in fixed-link PHYs).

Fixes 92399

Copy link
Member

@maass-hamburg maass-hamburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw this code part is up for removal with #91572, but that will only be merged after the next release.

Update the driver to handle -ENOSYS from phy_configure_link(), which is
now returned when the cfg_link callback is missing (e.g., in fixed-link
PHYs).

Signed-off-by: Ofir Shemesh <ofirshemesh777@gmail.com>
@ofirshe ofirshe force-pushed the nxp-enet-phy-fixed-link-fix branch from 1bc05cb to 5ba079e Compare July 1, 2025 07:33
@ofirshe ofirshe requested a review from maass-hamburg July 1, 2025 07:34
Copy link

sonarqubecloud bot commented Jul 1, 2025

@maass-hamburg maass-hamburg added the bug The issue is a bug, or the PR is fixing a bug label Jul 1, 2025
@dleach02 dleach02 added this to the v4.2.0 milestone Jul 1, 2025
@dleach02 dleach02 added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jul 1, 2025
@dkalowsk dkalowsk merged commit b2d7094 into zephyrproject-rtos:main Jul 1, 2025
33 checks passed
@ofirshe ofirshe deleted the nxp-enet-phy-fixed-link-fix branch July 1, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet bug The issue is a bug, or the PR is fixing a bug platform: NXP Drivers NXP Semiconductors, drivers Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<err> eth_nxp_enet_mac: phy_configure_link failed with error: -88
6 participants