-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add Quectel lx6 GNSS driver #92310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Quectel lx6 GNSS driver #92310
Conversation
3a01467
to
0b306e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Could you add the new driver to the https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/gnss/gnss_api test suite and run it as well?
To be used by the Quectel lx6 GNSS driver. Signed-off-by: Nick Ward <nix.ward@gmail.com>
Add Quectel lx6 driver, tested with L96 on I2C bus. Signed-off-by: Nick Ward <nix.ward@gmail.com>
I2C build of driver tested but UART build untested and experimental. Signed-off-by: Nick Ward <nix.ward@gmail.com>
Add I2C and UART build variants. Signed-off-by: Nick Ward <nix.ward@gmail.com>
Awesome, I ran the test suite on my out of tree board and made a change to now make the driver pass:
|
|
#include "gnss_nmea0183_match.h" | ||
#include "gnss_parse.h" | ||
|
||
#include <stdio.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why include stdio?
} | ||
} | ||
|
||
return modem_pipe_close(data->pipe, K_SECONDS(10)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to close the pipe before disconnecting vcc, if that actually powers down the modem you could get garbage data on the UART or frame errors as the UART bus may be "floating"
For the GNSS API test suite, you may want to add zephyr/tests/drivers/gnss/gnss_api/boards/native_sim.conf Lines 1 to 13 in 6c68584
|
Add Quectel I2C modem backend
Add Quectel lx6 GNSS driver
Add I2C and UART lx6 variants to GNSS build_all test
Add build warning when building untested UART build variant (I only have I2C lx6 hardware)