Skip to content

drivers: intc_dw: support multiple instances #92268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afongTT
Copy link

@afongTT afongTT commented Jun 26, 2025

Update the initializers to support platforms with multiple instances of the DesignWare interrupt aggregator. Also ensure that the initialize function calls irq_enable(). The calculation of the _sw_isr_table entry also now takes CONFIG_GEN_IRQ_START_VECTOR into account.

Copy link

Hello @afongTT, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@cfriedt cfriedt marked this pull request as ready for review June 26, 2025 20:05
@github-actions github-actions bot requested review from dcpleung and nashif June 26, 2025 20:06
ycsin
ycsin previously approved these changes Jun 27, 2025
INTC_INST_ISR_TBL_OFFSET(0), DT_INST_INTC_GET_AGGREGATOR_LEVEL(0));
#define INTC_DW_DEVICE_INIT(inst) \
\
static void dw_ictl_config_irq_##inst(const struct device *port) \
Copy link
Member

@ycsin ycsin Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the port arg is probably not required in the future as well since we customized it for every instance

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unused port argument.

Update the initializers to support platforms with multiple instances
of the DesignWare interrupt aggregator. Also ensure that the initialize
function calls irq_enable(). The calculation of the _sw_isr_table entry
also now takes CONFIG_GEN_IRQ_START_VECTOR into account.

Signed-off-by: Aaron Fong <afong@tenstorrent.com>
Copy link

sonarqubecloud bot commented Jul 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants