driver: pwm: create ambiq pwm driver #92214
Open
+2,212
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
cc16812 to
fb928ca
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds support for Ambiq PWM via both TIMER and CTIMER peripherals, including driver implementations, device tree bindings, and board/sample overlays.
- Introduce two new PWM drivers (
pwm_ambiq_timerandpwm_ambiq_ctimer) with full Zephyr driver API implementations - Add DTS binding schemas (
ambiq,timer-pwm.yaml,ambiq,ctimer-pwm.yaml) and include<zephyr/dt-bindings/pwm/pwm.h>in Ambiq SoC DTS files - Update Kconfig, CMakeLists, and board/sample overlays to enable and test the new PWM controllers
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/pwm/pwm_ambiq_timer.c | Implements TIMER-based PWM driver and init logic |
| drivers/pwm/pwm_ambiq_ctimer.c | Implements CTIMER-based PWM driver and init logic |
| dts/bindings/pwm/ambiq,timer-pwm.yaml | Defines binding schema for ambiq,timer-pwm |
| dts/bindings/pwm/ambiq,ctimer-pwm.yaml | Defines binding schema for ambiq,ctimer-pwm |
| drivers/pwm/Kconfig.ambiq_timer | Adds Kconfig entries for both Ambiq PWM drivers |
| drivers/pwm/CMakeLists.txt | Registers new PWM drivers in build |
| dts/arm/ambiq/ambiq_apollo510.dtsi | Includes PWM DTS entries under timer@… nodes |
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
fb928ca to
923d9ac
Compare
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
923d9ac to
0aa7d0e
Compare
pdgendt
previously requested changes
Jun 26, 2025
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
0aa7d0e to
181b0e2
Compare
pdgendt
reviewed
Jun 26, 2025
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
181b0e2 to
be33d2a
Compare
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
2 times, most recently
from
c7d67cd to
8db324d
Compare
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
aaronyegx,
anangl,
andyross,
henrikbrixandersen,
jeppenodgaard,
kartben,
Mani-Sadhasivam and
nashif
github-actions
bot
requested review from
nordic-krch,
RichardSWheatley,
simonguinot and
teburd
RichardSWheatley
previously approved these changes
Jun 26, 2025
|
@kartben please help to review this PR, thank you! |
It looks reasonable but would be good to have PWM people review as I know close to nothing about PWM :) |
|
@AlessandroLuo Also, it's highly unlikely this can make the cut for tomorrow's feature freeze given this will have been in review for less than two days by then. Release managers might allow exceptions though :) |
aaronyegx
previously approved these changes
Jun 27, 2025
anangl
reviewed
Jun 27, 2025
AlessandroLuo
dismissed stale reviews from aaronyegx and RichardSWheatley
via
8a7a1fe
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
2 times, most recently
from
8a7a1fe to
42bdc29
Compare
anangl
reviewed
Jun 27, 2025
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
42bdc29 to
cf5eae2
Compare
aaronyegx
reviewed
Jun 30, 2025
Restructured counter and timer. CTimer/Timer is now parent to pwm and counter. Created PWM driver and tied to pwm and pwm-led Signed-off-by: Richard Wheatley <richard.wheatley@ambiq.com>
Move clk-source from pwm to timer change associated files to match Signed-off-by: Richard Wheatley <richard.wheatley@ambiq.com>
check for max number of children in timer. Signed-off-by: Richard Wheatley <richard.wheatley@ambiq.com>
changed variable names from timer to ctimer Signed-off-by: Hao Luo <hluo@ambiq.com>
This commit adds support for Apollo510 pwm driver Signed-off-by: Hao Luo <hluo@ambiq.com>
AlessandroLuo
force-pushed
the
ambiq-pwm-merge
branch
from
cf5eae2 to
cfaf1a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Ambiq PWM driver based on the on-chip timer/ctimer peripherals and integrates it into Zephyr’s build and DT infrastructure.