drivers: i3c: Add MAX32657 I3C driver #92171
Conversation
github-actions
bot
requested review from
dcpleung,
galak,
MaureenHelm,
microbuilder,
ozersa,
XenuIsWatching and
yasinustunerg
Add I3C driver for ADI MAX32 microcontrollers. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Add I3C instance to max32657.dtsi. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Enables shell support for MAX32 I3C driver. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Add I3C node to MAX32657EVKIT board devicetree and add I3C to the list of supported drivers. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Add support for ADXL367 accelerometer connected to I3C bus. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
|
| # Enable I3C | ||
| CONFIG_I3C=y |
There was a problem hiding this comment.
This enables I3C for all applications built for this board, even hello world. Should be removed
There was a problem hiding this comment.
Fails to build sensor samples that is why I added it. I will think of a better solution.
https://github.com/zephyrproject-rtos/zephyr/actions/runs/15874279583/job/44758423761
| # Enable I3C | ||
| CONFIG_I3C=y |
| * | ||
| */ | ||
| static void max32_i3c_interrupt_enable(mxc_i3c_regs_t *regs, uint32_t mask) | ||
| { |
There was a problem hiding this comment.
why this function isn't defined as 'inline' ? any specific reason ?
| static int max32_i3c_do_one_xfer_read(mxc_i3c_regs_t *regs, uint8_t *buf, uint8_t buf_sz, bool ibi) | ||
| { | ||
| int ret = 0; | ||
| int offset = 0; |
There was a problem hiding this comment.
Is negative offset execpected in this function ? if not define this as uint ?
| int ret = 0; | ||
| int offset = 0; | ||
| int readb = 0; | ||
|
|
There was a problem hiding this comment.
Is negative "readb" execpected in this function ? if not define this as uint ?
Adds I3C controller driver for MAX32657. Only controller mode is supported at the moment. Based on existing MCUX I3C driver.