Revert "drivers: serial: nrfx_uarte: Deprecate CONFIG_UART_x_NRF_HW_A… #92156
Conversation
github-actions
bot
added
area: Modem
area: Samples
github-actions
bot
requested review from
bjarki-andreasen,
dcpleung,
jukkar,
kartben,
nashif,
pdgendt,
rlubos,
ssharks and
tomi-font
nordic-krch
force-pushed
the
uarte_hw_async
branch
2 times, most recently
from
5824401 to
e12bbc8
Compare
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordic-krch
force-pushed
the
uarte_hw_async
branch
from
e12bbc8 to
9f4c28d
Compare
nordic-krch
force-pushed
the
uarte_hw_async
branch
2 times, most recently
from
41ebd3a to
8d1be06
Compare
In certain configurations timeout field is not present in the data structure so preprocessor ifdef must be used instead of compiler check. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
…SYNC" This reverts commit 384e940. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
…ndency Enhanced RX cannot be used when UART_x_NRF_HW_ASYNC is used so changing default value to depends on. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
uarte_hw_async
branch
from
8d1be06 to
3ae8d74
Compare
|
@anangl @masz-nordic can you take a look? |
|
@nordic-krch is this needed for 4.2? |
|
No. It's ok to pull it in after the release. |
|
I would argue that it should be in 4.2. It's already suboptimal to bring back a deprecated feature IMO, so waiting one more release will be even more confusing. |
|
@kartben @danieldegrasse if it is not too late then that would be very good |
Is there a timeline to re-deprecate this feature? It would also be good to understand why we need to revive this- I guess the new method of byte counting still has some error conditions, so this method is needed? |
|
@nordic-krch I'm okay with this going back in, but I'd like to ask for a release-note or migration guide update as well. Specifically calling out why this is being re-enabled and the expected EOL for it. |
|
We found out that new method has corner and it is not 100% reliable without HWFC and old approach is. So it's permanent de-deprecation. I will add the release note. |
Add note in release notes for v4.2 about de-deprecation of CONFIG_CONFIG_UART_x_NRF_HW_ASYNC option. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
|
…SYNC"
This reverts commit 384e940.
Feature was deprecated some time ago but we see that there is a need to keep it.