Skip to content

dts: arm: adi: Enable SPI for MAX32657 #92036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

ttmut
Copy link
Contributor

@ttmut ttmut commented Jun 23, 2025

Enable SPI support for MAX32657 and add test overlays to spi_loopback for both secure and nonsecure variants of MAX32657EVKIT.

MaureenHelm
MaureenHelm previously approved these changes Jun 23, 2025
@MaureenHelm MaureenHelm added this to the v4.2.0 milestone Jun 23, 2025
ozersa
ozersa previously approved these changes Jun 23, 2025
@ttmut ttmut dismissed stale reviews from ozersa and MaureenHelm via 9d78bed June 24, 2025 07:37
@ttmut ttmut requested review from ozersa and MaureenHelm June 24, 2025 07:40
@ttmut ttmut added the DNM This PR should not be merged (Do Not Merge) label Jun 24, 2025
MAX32657 introduces changes for registers named (master, slave) to
(controller, target) this causes build issues

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
Add SPI node to MAX32657 dtsi file

Signed-off-by: Mert Ekren <mert.ekren@analog.com>

226e230b349on how to improve this.
Add SPI into '.yaml' files.

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
@ttmut ttmut removed the DNM This PR should not be merged (Do Not Merge) label Jun 24, 2025
MaureenHelm
MaureenHelm previously approved these changes Jun 24, 2025
ozersa
ozersa previously approved these changes Jun 25, 2025
Copy link
Contributor

@ozersa ozersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incase of an update requires, nice to update copyright date too, as 2024-2025.

@ttmut
Copy link
Contributor Author

ttmut commented Jun 25, 2025

Incase of an update requires, nice to update copyright date too, as 2024-2025.

The commit updating the driver dates back to 2024 so I am not sure if we should update the copyright in this case. Regardless, I have realized I need to update the copyright date for the driver in #92027.

decsny
decsny previously approved these changes Jun 25, 2025
#
# SPDX-License-Identifier: Apache-2.0
#
CONFIG_SPI_ASYNC=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already enabled in prj.conf of spi loopback test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed them.

Enable 'spi_loopback' test for MAX32657 boards.

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
@ttmut ttmut dismissed stale reviews from decsny, ozersa, and MaureenHelm via 6ffe69c June 25, 2025 15:29
Copy link

@danieldegrasse danieldegrasse merged commit e7dd1e5 into zephyrproject-rtos:main Jun 27, 2025
28 checks passed
@MaureenHelm MaureenHelm deleted the max32657/spi branch June 27, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: SPI SPI bus platform: ADI Analog Devices, Inc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants