Skip to content

toolchain: Add the __deprecated_version macro #91934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rruuaanng
Copy link
Collaborator

For more to see #87662

Closes: #87662

@rruuaanng rruuaanng force-pushed the impr-dep-macro branch 2 times, most recently from bad5d4e to 7a8f165 Compare June 20, 2025 09:30
@rruuaanng rruuaanng marked this pull request as ready for review June 20, 2025 14:22
@github-actions github-actions bot added Release Notes To be mentioned in the release notes area: Toolchains Toolchains labels Jun 20, 2025
@rruuaanng rruuaanng requested a review from nashif June 21, 2025 01:43
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the warning message output by this macro is rather cryptic:

test.c:19:5: warning: 'foo' is deprecated: 4.3 [-Wdeprecated-declarations]

The message should be more clear to say something like "planned removal in v4.3"

Add the `__deprecated_version` macro to print version
information when deprecation warnings are triggered.

Signed-off-by: James Roy <rruuaanng@outlook.com>
Add the `__deprecated_version` macro to print version
information when deprecation warnings are triggered.

Signed-off-by: James Roy <rruuaanng@outlook.com>
Add `__deprecated_version` macro to the Toolchain entry list.

Signed-off-by: James Roy <rruuaanng@outlook.com>
Copy link

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update checkpatch attribute list:

our $Attribute = qr{

And would be nice to update tags.sh as well so that these show up in the same way as __deprecated:

-I __acquires,__releases,__deprecated \

@rruuaanng rruuaanng changed the title toolchain: Add the TOOLCHAIN_DEPRECATED macro toolchain: Add the __deprecated_version macro Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Toolchains Toolchains Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the deprecation macro
5 participants