BAP Broadcast Assistant sonarcloud fixes #91589
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses SonarCloud-reported maintainability issues in the BAP Broadcast Assistant discovery logic by separating index computation from state-count increment and adding handling for unexpected UUIDs.
- Split
recv_state_cntincrement out of the index assignment to avoid side effects. - Introduced an
elsebranch to abort discovery on invalid UUIDs with an error callback. - Adjusted log placement around
recv_state_cnt.
Comments suppressed due to low confidence (2)
subsys/bluetooth/audio/bap_broadcast_assistant.c:710
- [nitpick] The log statement prints
inst->recv_state_cntbefore it is incremented, changing the original behavior. Consider loggingidxor moving this log after theinst->recv_state_cnt++increment to reflect the correct count.
LOG_DBG("Receive State %u", inst->recv_state_cnt);
subsys/bluetooth/audio/bap_broadcast_assistant.c:720
- Passing
0forrecv_state_counton error hides how many states were discovered before the failure. Consider passinginst->recv_state_cntto give callers the actual count.
bap_broadcast_assistant_discover_complete(conn, -EBADMSG, 0);
github-actions
bot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
Thalley
force-pushed
the
bap_ba_sonarcloud_fixes
branch
from
a8f09a9 to
39663bf
Compare
If the chrc->uuid is somehow an invalid UUID, we log it and terminate the discovery procedure. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Sonarcloud does not allow to use the result of a incremental (++) as an assignment. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bap_ba_sonarcloud_fixes
branch
from
39663bf to
1ef7d2f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues reported by Sonarcloud