cmake: linker: separate toolchain_ld_options() calls for grouped flags #91515
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
|
Hi @tejlmand, does this fix seem ok to you ? |
|
Sorry for the pings @nashif @tejlmand @stephanosio @nordicjm @57300, could you provide feedback on this ? |
Fymyte
force-pushed
the
toolchain-ld-flags
branch
from
39276db to
5c7c671
Compare
|
I removed the surrounding if check for the existence of |
|
Hi @tejlmand, I was wondering if someone could review this MR before the 4.2 release. The underlying issue prevents us from linking because the default |
Fixes zephyrproject-rtos#91045 Adding NO_SPLIT in the TOOLCHAIN_LD_FLAGS list caused every flags in the list to be checked together by the linker. This caused issues where incompatible flags was passed together, and the result was that none was propagated to the linker. By using separate variables, we can achieve the initial goal of NO_SPLIT to only group a sub-set of flags. Signed-off-by: Pierrick Guillaume <pguillaume@fymyte.com>
Fymyte
force-pushed
the
toolchain-ld-flags
branch
from
5c7c671 to
055a7e3
Compare
|
Rebased and fixed conflicts |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91045
Adding NO_SPLIT in the TOOLCHAIN_LD_FLAGS list caused every flags in the list to be checked together by the linker. This caused issues where incompatible flags was passed together, and the result was that none was propagated to the linker.
By using separate variables, we can achieve the initial goal of NO_SPLIT to only group a sub-set of flags.