drivers: timer: nrf_grtc_timer: add last_count initialization #91432
Conversation
github-actions
bot
added
area: Timer
github-actions
bot
requested review from
anangl,
andyross,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
teburd
drivers/timer/nrf_grtc_timer.c
Outdated
| @@ -485,6 +485,7 @@ static int sys_clock_driver_init(void) | |||
| } | |||
| #endif /* CONFIG_NRF_GRTC_START_SYSCOUNTER */ | |||
|
|
|||
| last_count = counter(); | |||
There was a problem hiding this comment.
shouldn't be wrapped in Kconfig-equivalent of NRFX_GRTC_CLEAR_AT_INIT ? or this feature is not configurable via Kconfig ?
There was a problem hiding this comment.
There is another PR for that: #89664
adamkondraciuk
dismissed stale reviews from kl-cruz, nika-nordic, and nordic-krch
via
ad3f2da
adamkondraciuk
force-pushed
the
NRFX-7834-update-last-count-at-grtc-init
branch
2 times, most recently
from
ad3f2da to
86c221f
Compare
drivers/timer/nrf_grtc_timer.c
Outdated
| last_count = sys_clock_tick_get() * CYC_PER_TICK; | ||
| grtc_start_value = last_count; |
There was a problem hiding this comment.
Is there a potential race between here and sys_clock_timeout_handler for last_count?
If that is not the case and sys_clock_announce is not expected to be called at this point, could this code be simplified and skip sys_clock_tick_get logic to just call counter()?
There was a problem hiding this comment.
It's definitely better to use counter() here to initialize both these variables than to involve sys_clock_tick_get() (calling this function from the system timer driver doesn't actually seem to be appropriate).
The GRTC counter is not cleared at startup, therefore the `last_count` variable needs to be initialized accordingly. This change: - Prevents overflow of the `sys_clock_announce()` int32_t parameter - Ensures the correct uptime value, which should be reset during initialization Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
Update GRTC tests to reflect uptime reset at startup. Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
adamkondraciuk
force-pushed
the
NRFX-7834-update-last-count-at-grtc-init
branch
from
86c221f to
6248aac
Compare
|
The GRTC counter is not cleared at startup, therefore the
last_countvariable needs to be initialized accordingly. This change:sys_clock_announce()int32_t parameterFixes nRF54L: uptime does not reset across reboots #89147