Skip to content

board: st: stm32u5g9j-dk2: Add toucscreen and hspi flash to u5g9 dk2 #91359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

board: st: stm32u5g9j-dk2: Add toucscreen and hspi flash to u5g9 dk2 #91359

wants to merge 3 commits into from
+77 −4

Conversation

markussmST
Copy link

Adds HSPI external flash and GT911 touch screen driver support to the STM32U5G9J-DK2 board.

@github-actions GitHub Actions
Copy link

Hello @markussmST, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@github-actions github-actions bot added the platform: STM32 ST Micro STM32 label Jun 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 10, 2025
@markussmST markussmST force-pushed the add-toucscreen-and-hspi-flash-to-u5g9-dk2 branch 2 times, most recently from 45498be to 3449259 Compare June 10, 2025 14:19
erwango
erwango requested changes Jun 11, 2025
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

etienne-lms
etienne-lms reviewed Jun 11, 2025
View reviewed changes
@markussmST markussmST force-pushed the add-toucscreen-and-hspi-flash-to-u5g9-dk2 branch from 3449259 to 7a7c261 Compare June 12, 2025 10:59
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Jun 12, 2025
@markussmST markussmST force-pushed the add-toucscreen-and-hspi-flash-to-u5g9-dk2 branch 3 times, most recently from 60b7ff0 to 72b6d0d Compare June 12, 2025 14:05
etienne-lms
etienne-lms reviewed Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside the few indentation issues, LGTM.

boards/st/stm32u5g9j_dk2/stm32u5g9j_dk2.dts Outdated
* pc9 and pb9 with LTDC node.
*/
* pc9 and pb9 with LTDC node.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you discard this change. The indentation was fine.

erwango
erwango requested changes Jun 12, 2025
View reviewed changes
west.yml Outdated
revision: 5cbc642b1a79d4f373b1587f8c3027f31bf0d30c
revision: e51136cb43ae2d7b9742d84a981280a09fb25138
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#90018 will probably be merged before this PR and will update hal_stm32 sha1 to a later version which will include current commit and few others.

To avoid issues, you'll then need to rebase but remove this modification to be sure we don't go back in time in hal_stm32.

@erwango
Copy link
Member

erwango commented Jun 13, 2025

#90018 has been merged and west.yaml points to a hal_stm32 version integration the commit we need, you can now rebase, remove west.yaml update and push a last version of the branch.

@markussmST markussmST force-pushed the add-toucscreen-and-hspi-flash-to-u5g9-dk2 branch from 72b6d0d to a1a59c1 Compare June 13, 2025 07:22
@markussmST
dts: Add hspi to STM32U5 chips including this
d4ac583 
The SOCs including this dts all have hspi (xspi comatible)
peripheral included.

Signed-off-by: Mathias Markussen <mathias.markussen@st.com>
@markussmST
board: st: stm32u5g9j-dk2: Add touchscreen driver
4dcb875 
Use GT911 touchscreen driver on STM32U5G9J-DK2

Signed-off-by: Mathias Markussen <mathias.markussen@st.com>
@markussmST
board: st: stm32u5g9j-dk2: Add HSPI external flash
77a5e79 
Add external HSPI flash on STM32U5G9J-DK2
Use external loader to flash it with STM32CubeProgrammer

Signed-off-by: Mathias Markussen <mathias.markussen@st.com>
@markussmST markussmST force-pushed the add-toucscreen-and-hspi-flash-to-u5g9-dk2 branch from a1a59c1 to 77a5e79 Compare June 13, 2025 09:57
@markussmST
Copy link
Author

Still works for me after rebasing. Should have all the whitespaces fixed as well.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@erwango erwango requested a review from etienne-lms June 13, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

At least 2 approving reviews are required to merge this pull request.

Assignees

@erwango erwango

Labels
platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markussmST @erwango @etienne-lms