video: sensors (ov5640/imx335) various improvements / fix #90820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset and powerdown pins are optionals. gpio_is_ready_dt should not be called in case of reset or powerdown are not present. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
github-actions
bot
added
area: Video
github-actions
bot
requested review from
dbaluta,
decsny,
dleach02,
josuah,
loicpoulain,
manuargue,
mmahadevan108,
ngphibang and
Raymond0225
added 3 commits
May 29, 2025 23:15
Rely on DT_ANY_INST_HAS_PROP_STATUS_OKAY to only build the gpio handling code for reset and powerdown pins if this is being used by one or more instance of the device. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Increase the T4 delay after releasing the reset of the sensor in order to avoid getting I2C communication issues at initialization time. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Rely on DT_ANY_INST_HAS_PROP_STATUS_OKAY to only build the gpio handling code for reset pin if this is being used by one or more instance of the device. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
avolmat-st
force-pushed
the
video_ov5640_imx335_fix_reset_powerdown
branch
from
25bae8d to
5d1c8f9
Compare
|
josuah
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On both OV5640 & IMX335 drivers, rely on DT_ANY_INST_HAS_PROP_STATUS_OKAY to reduce the footprint related to gpio reset/powerdown handling if those pins aren't being used.
Add a stability fix for the IMX335 in order to avoid getting i2c errors right after the IMX335 initialization.