Fix spi loopback thread test on fail case #90766
Open
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test that checks latency also prints a measurement of the latency which is just a visual information for the test output. However, this print uses a subtraction which can have an overflow in the case where the kernel timer is behind, so just clamp to 0 in that case where there is an overflow. This change does not affect the test pass/fail logic. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves the handling of failure cases in the SPI loopback thread test and corrects an error in the latency measurement log output. Key changes include:
- Adding an overflow check for latency measurement before printing.
- Replacing immediate assertions in SPI transfer threads with error logging via an atomic counter.
- Aggregating thread test failures after joins with an assertion to determine overall test success.
decsny
force-pushed
the
spi_loopback_test_fixes
branch
from
f2cab8f to
2f3f7ae
Compare
Right now the thread test case does not handle when the test fails, the test will be aborted by ztest in one of the spawned threads, and cause desynchronization which messes up the rest of the test. Fix by synchronizing in the case of fails and return fail from main test thread instead of the spawned ones. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
spi_loopback_test_fixes
branch
from
2f3f7ae to
b2b1198
Compare
|
tbursztyka
approved these changes
May 29, 2025
kartben
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of thread test failing, it is not handled well and will mess up the execution of the rest of the test. This can be fixed as is done in the PR.
Also fixes a mistake on a value printed in the test log for the latency test, this problem did not actually affect the pass/fail of the test and neither does the fix to it.