Skip to content

Update Document for nxp_m2_wifi_bt Shield with Hardware-Rework and Correct Wi-Fi Shell Build Command #90749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nirav-agrawal
Copy link
Contributor

  • Update hardware rework details require for Bluetooth HCI UART and I2S interfaces to work with M.2 module.
  • Update west build command for Wi-Fi shell app with extra config overlay file.

@github-actions github-actions bot added the area: Shields Shields (add-on boards) label May 28, 2025
DerekSnell
DerekSnell previously approved these changes May 28, 2025
@nirav-agrawal
Copy link
Contributor Author

Hi @kartben , I need your help to understand compliance error with this PR. I tried to update the image from PNG to SVG which reduces image size from 5.47mb to 837kb. It seems the size needs smaller than 100kb which seems not possible. can you suggest if there is any alternate to it?

@nirav-agrawal nirav-agrawal requested a review from DerekSnell May 29, 2025 03:26
@kartben
Copy link
Collaborator

kartben commented May 29, 2025

Hi @kartben , I need your help to understand compliance error with this PR. I tried to update the image from PNG to SVG which reduces image size from 5.47mb to 837kb. It seems the size needs smaller than 100kb which seems not possible. can you suggest if there is any alternate to it?

SVG is not meant to be used for photos :)
Just use tinypng.com or the cwebp command line locally to convert to webp. Also make sure to resize the image to like 1000px width
FWIW, a good alternative would probably be to simply add an external link to the shield documentation on NXP website, which I'm guessing is more complete and will have the merit of always being up-to-date

- Update hardware rework details require for Bluetooth HCI UART and
 I2S interfaces to work with M.2 module.
- Update west build command for Wi-Fi shell app with extra config
 overlay file.

Signed-off-by: Nirav Agrawal <nirav.agrawal@nxp.com>
@nirav-agrawal nirav-agrawal force-pushed the update_nxp_shield_doc branch from 0aae533 to 0a541ba Compare May 29, 2025 08:39
@nirav-agrawal
Copy link
Contributor Author

Hi @kartben , I need your help to understand compliance error with this PR. I tried to update the image from PNG to SVG which reduces image size from 5.47mb to 837kb. It seems the size needs smaller than 100kb which seems not possible. can you suggest if there is any alternate to it?

SVG is not meant to be used for photos :) Just use tinypng.com or the cwebp command line locally to convert to webp. Also make sure to resize the image to like 1000px width FWIW, a good alternative would probably be to simply add an external link to the shield documentation on NXP website, which I'm guessing is more complete and will have the merit of always being up-to-date

Hi @kartben, thank you so much for your suggestions. now I have used webp after converting it from png to and tried to keep it under 100kb. In future when we have such link available from the company site, we will use it here. :)

Copy link

@nirav-agrawal
Copy link
Contributor Author

@kartben, can you help approve and merge this PR? thank you :)

@kartben
Copy link
Collaborator

kartben commented May 29, 2025

@kartben, can you help approve and merge this PR? thank you :)

Sure, but it hasn't even been open for 24 hours :)

I will have a look, but this won't be merged until it's been in review for at least 2 business days anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shields Shields (add-on boards) platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants