bluetooth: improve the controller address resolution enablement

[MarkWangChinese]

If the controller resolving list is cleared by HCI_LE_Clear_Resolving_List, don't need to enable the controller address resolution.

I think it is one improvement, please help to review.

[Copilot]

Pull Request Overview

This PR refines when the Bluetooth controller’s address resolution is re-enabled by introducing a flag to skip re-enabling if disabling failed or the resolving list was cleared.

• Add enable_controller_res flag initialized to true.
• Set the flag to false on disable failure or after clearing the resolving list.
• Wrap the final addr_res_enable(BT_HCI_ADDR_RES_ENABLE) call in a conditional based on the flag.

Comments suppressed due to low confidence (2)

subsys/bluetooth/host/id.c:1014

• [nitpick] Consider renaming enable_controller_res to should_enable_controller_res or reenable_controller_res for clearer intent.

bool enable_controller_res = true;

subsys/bluetooth/host/id.c:1085

• Add a test case to cover the scenario where the resolving list is cleared so that address resolution is not re-enabled.

enable_controller_res = false;

[Copilot]

Pull Request Overview

Improve controller address resolution enablement by skipping re-enablement when the resolving list is cleared or when a disable command fails.

• Introduce enable_controller_res flag to track whether resolution should be re-enabled
• Set flag to false on disable failure and after clearing the resolving list
• Wrap final addr_res_enable(BT_HCI_ADDR_RES_ENABLE) call in a conditional based on the flag

Comments suppressed due to low confidence (3)

subsys/bluetooth/host/id.c:1014

• [nitpick] The variable name enable_controller_res is a bit ambiguous. Consider renaming it to something like should_enable_addr_res or should_reenable_controller_res for clarity.

bool enable_controller_res = true;

subsys/bluetooth/host/id.c:1126

• The return value of addr_res_enable is not checked here. It would be safer to capture and log any error to aid debugging if re-enablement fails.

addr_res_enable(BT_HCI_ADDR_RES_ENABLE);

subsys/bluetooth/host/id.c:1085

• Add tests to cover the scenario where the resolving list is cleared and enable_controller_res is false, ensuring address resolution isn’t re-enabled unexpectedly.

enable_controller_res = false;

[Copilot]

[nitpick] Minor: consider adjusting comment capitalization and consistency, e.g., "address resolution" in lowercase, to match code style.

Suggested change

	/* since the controller resolving list is cleared,
	* don't need to enable the Address Resolution.
	/* Since the controller resolving list is cleared,
	* don't need to enable the address resolution.

[Thalley]

Just some minor typing stuff in the comments, otherwise LGTM

[Copilot]

Pull Request Overview

This PR refines when the controller’s address resolution is re-enabled by introducing a flag to skip re-enablement if the resolving list was just cleared or if disabling failed.

• Add enable_controller_res flag to track whether to call addr_res_enable at the end
• Set flag to false when disable fails or when the resolving list is cleared
• Wrap final addr_res_enable(BT_HCI_ADDR_RES_ENABLE) in a conditional based on the new flag

Comments suppressed due to low confidence (2)

subsys/bluetooth/host/id.c:1014

• [nitpick] The flag name enable_controller_res can be ambiguous. Consider renaming it to something like should_enable_controller_res to clearly indicate it controls whether re-enablement should occur.

bool enable_controller_res = true;

subsys/bluetooth/host/id.c:1085

• This new path where enable_controller_res is set to false after clearing the resolving list should be covered by a unit or integration test to ensure resolution is not re-enabled in this scenario.

enable_controller_res = false;

[Copilot]

[nitpick] The comment could be clearer and more concise. For example: /* On disable failure, resolution remains enabled—no need to re-enable. */

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud