Skip to content

Conversation

nzmichaelh
Copy link
Contributor

The ch32v006evt has 8 KiB of RAM which is enough for many of the basic samples but, by default, Twister assumes that a sample needs 16 KiB of RAM.

Mark some of the samples as needing 8 KiB of RAM so the ch32v006evt gets better CI coverage.

@nzmichaelh
Copy link
Contributor Author

Note that Twister should fail at the moment, but then pass once #90438 is merged and I rebase.

@nzmichaelh nzmichaelh marked this pull request as ready for review May 27, 2025 18:46
@github-actions github-actions bot added area: Samples Samples area: LED Label to identify LED subsystem area: Watchdog Watchdog labels May 27, 2025
@nzmichaelh
Copy link
Contributor Author

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690

but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

@kartben
Copy link
Contributor

kartben commented May 28, 2025

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690

but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

Twister only runs on integration_platforms: on pull requests and when push to main (i.e. merge). It's only in the weekly CI run that the rest of the platforms are included.

@nzmichaelh
Copy link
Contributor Author

Hmm, Twister ran: https://github.com/zephyrproject-rtos/zephyr/actions/runs/15291782992/job/43012659289?pr=90690
but the results don't include the ch32v006evt, but do pass for boards like gd32e103v_eval, frdm_k22f. I'll investigate as I suspect there's a default platform list.

Twister only runs on integration_platforms: on pull requests and when push to main (i.e. merge). It's only in the weekly CI run that the rest of the platforms are included.

Thanks. Still sounds worthwhile then, and the developer can do a twister --vendor wch manually.

@kartben
Copy link
Contributor

kartben commented Jun 6, 2025

I'm fine with the change but the commit message is off -- it should simply refer to the fact you're lowering the min RAM requirements

The ch32v006evt has 8 KiB of RAM which is enough for many of the basic
samples but, by default, Twister assumes that a sample needs 16 KiB
of RAM.

Mark some of the samples as needing 8 KiB of RAM so the ch32v006evt
gets better CI coverage.

Signed-off-by: Michael Hope <michaelh@juju.nz>
Copy link

@kartben
Copy link
Contributor

kartben commented Jul 25, 2025

@nzmichaelh can you please fix the commit message / PR description when you have a chance? (see earlier comments)

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 24, 2025
@github-actions github-actions bot closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: LED Label to identify LED subsystem area: Samples Samples area: Watchdog Watchdog Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants