Skip to content

i3c: fix coverity discovered issues #90686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

i3c: fix coverity discovered issues #90686

wants to merge 2 commits into from

Conversation

dcpleung
Copy link
Member

  • i3c: rtio: deal with rtio_cqe_consume() returning NULL
  • i3c: set default return for i3c_device_adv_info_get()

This was linked to issues May 27, 2025
[Coverity CID: 524779] Dereference null return value in drivers/i3c/i3c_rtio.c #90473
Open
[Coverity CID: 524759] Dereference null return value in drivers/i3c/i3c_rtio.c #90489
Open
[Coverity CID: 524751] Dereference null return value in drivers/i3c/i3c_rtio.c #90497
Open
[Coverity CID: 520280] Uninitialized scalar variable in drivers/i3c/i3c_common.c #90509
Open
@dcpleung dcpleung marked this pull request as ready for review May 27, 2025 23:01
@dcpleung
Copy link
Member Author

Twister error is unrelated to this.

@github-actions github-actions bot requested a review from XenuIsWatching May 27, 2025 23:02
dcpleung added 2 commits May 27, 2025 16:33
@dcpleung
i3c: set default return for i3c_device_adv_info_get()
b542052 
Coverity flagged that the return variable ret may not be
initialized when returning. So give it a default value.

Fixes zephyrproject-rtos#90509

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung
i3c: rtio: deal with rtio_cqe_consume() returning NULL
0d268fa 
rtio_cqe_consume() may return NULL so we need to check before
using any members of the returned struct.

Fixes zephyrproject-rtos#90473
Fixes zephyrproject-rtos#90489
Fixes zephyrproject-rtos#90497

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdgendt pdgendt pdgendt approved these changes

@XenuIsWatching XenuIsWatching XenuIsWatching approved these changes

Assignees

@dcpleung dcpleung

Labels
area: I3C
Projects
None yet
Milestone
No milestone
3 participants
@dcpleung @pdgendt @XenuIsWatching