ST DTS lint #90611
ST DTS lint #90611
Conversation
github-actions
bot
requested review from
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
HoZHel,
marwaiehm-st and
mathieuchopstm
| @@ -117,6 +117,7 @@ arduino_i2c: &i2c1 {}; | |||
| &spi1_miso_pa6 &spi1_mosi_pa7>; | |||
| pinctrl-names = "default"; | |||
| status = "okay"; | |||
|
|
|||
There was a problem hiding this comment.
from the specs, I guess we should rather have:
pinctrl-names = "default";
+ cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;
status = "okay";
- cs-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;
lora: lora@0 {There was a problem hiding this comment.
This exists in a bunch of places. I think it falls into the category of splitting into paragraphs for readabillity. It's nice to have the cs-gpios right before the spi device sub-nodes because they go together logically
| @@ -170,6 +170,7 @@ | |||
| pinctrl-0 = <&spi2_sck_pd1 &spi2_miso_pd3 &spi2_mosi_pc3>; | |||
| pinctrl-names = "default"; | |||
| status = "okay"; | |||
|
|
|||
There was a problem hiding this comment.
pinctrl-names = "default";
+ cs-gpios = <&gpiod 0 GPIO_ACTIVE_LOW>;
status = "okay";
- cs-gpios = <&gpiod 0 GPIO_ACTIVE_LOW>;
spbtle_1s_sensortile_box: spbtle-1s@0 {| reg = <0x00020000 DT_SIZE_K(128)>; | ||
| label = "image-0"; | ||
| }; |
There was a problem hiding this comment.
By the way, could you add an empty lines beofre node slot1_partition and before node scratch_partition below. There are missing.
|
|
||
| ext-sdram = <&psram>; | ||
|
|
||
| status = "okay"; | ||
|
|
||
| width = <800>; | ||
| height = <480>; | ||
| pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>; |
There was a problem hiding this comment.
A bit more to address here?
Also needed in boards/st/stm32mp135f_dk/stm32mp135f_dk.dts, boards/st/stm32h7b3i_dk/stm32h7b3i_dk.dts, boards/st/stm32h750b_dk/stm32h750b_dk.dts, boards/st/stm32f7508_dk/stm32f7508_dk.dts, boards/st/stm32f746g_disco/stm32f746g_disco.dts and boards/st/stm32f429i_disc1/stm32f429i_disc1.dts.
disp-on-gpios = <&gpioq 3 GPIO_ACTIVE_HIGH>;
bl-ctrl-gpios = <&gpioq 6 GPIO_ACTIVE_HIGH>;
- status = "okay";
ext-sdram = <&psram>;
width = <800>;
height = <480>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
+ def-back-color-red = <0xFF>;
+ def-back-color-green = <0xFF>;
+ def-back-color-blue = <0xFF>;
+
+ status = "okay";
+
display-timings {
compatible = "zephyr,panel-timing";
de-active = <0>;
pixelclk-active = <0>;
hsync-active = <0>;
vsync-active = <0>;
hsync-len = <4>;
vsync-len = <4>;
hback-porch = <8>;
vback-porch = <8>;
hfront-porch = <8>;
vfront-porch = <8>;
};
-
- def-back-color-red = <0xFF>;
- def-back-color-green = <0xFF>;
- def-back-color-blue = <0xFF>;
};According to the guidelines the `reg` property should always come before any other property other than `compatible`. Link: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html Signed-off-by: Yishai Jaffe <yishai1999@gmail.com>
According to the guidelines the `status` property should always be the last property listed. Link: https://docs.kernel.org/devicetree/bindings/dts-coding-style.html Signed-off-by: Yishai Jaffe <yishai1999@gmail.com>
|
Fixed two issues according to the device tree guidelines https://docs.kernel.org/devicetree/bindings/dts-coding-style.html:
regproperty should be second only to thecompatibleproperty within a node. This was not the case in many partition nodes definitions.statusproperty should be the last property in a node.