bluetooth: smp: CTKD issue when cross br and ble connections and security #90574
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
github-actions
bot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
alwa-nordic
requested review from
lylezhu2012
and removed request for
alwa-nordic
MarkWangChinese
force-pushed
the
feature/cross_br_ble_conns_security_ctkd_issue
branch
from
c0cf761 to
5d6b8f1
Compare
lylezhu2012
reviewed
May 28, 2025
subsys/bluetooth/host/smp.c
Outdated
| { | ||
| struct bt_keys *keys = data; | ||
|
|
||
| if (!bt_addr_le_is_identity(&conn->le.dst) && |
There was a problem hiding this comment.
Suggested change
| if (!bt_addr_le_is_identity(&conn->le.dst) && | |
| if (!bt_addr_le_is_rpa(&conn->le.dst)) { | |
| return; | |
| } | |
| if ( |
…rity The peer uses the RPA address. A BR connection is created firstly, a subsequent BLE connection is created secondly, the BR SMP CTKD occur thirdly (The BLE LTK is derived from BR and the BR SMP distribute peer's IRK and identity address here), but the BLE LTK is saved to key pool that is not matched with the previous BLE connection because the derived LTK is saved with identity address and BLE connection uses RPA. Fix it by: Resolve the BLE connections' RPA with the derived IRK to find the previous BLE connections and match the connections with derived LTK key. Signed-off-by: Mark Wang <yichang.wang@nxp.com>
MarkWangChinese
force-pushed
the
feature/cross_br_ble_conns_security_ctkd_issue
branch
from
5d6b8f1 to
3da815d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer uses the RPA address.
A BR connection is created firstly, a subsequent BLE connection is created secondly, the BR SMP CTKD occur thirdly (The BLE LTK is derived from BR and the BR SMP distribute peer's IRK and identity address here), but the BLE LTK is saved to key pool that is not matched with the previous BLE connection because the derived LTK is saved with identity address and BLE connection uses RPA. Fix it by: Resolve the BLE connections' RPA with the derived IRK to find the previous BLE connections and match the connections with derived LTK key.