Skip to content

samples: drivers: video: fix capture_to_lvgl statistics #90461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

NinoSc
Copy link
Contributor

@NinoSc NinoSc commented May 25, 2025

video capture_to_lvgl didn't show statistics because CONFIG_LV_USE_PERF_MONITOR depends on CONFIG_LV_USE_SYSMON. CONFIG_LV_USE_DROPDOWN is required as well.
Link: #90428 (comment)

@github-actions github-actions bot added area: Samples Samples area: Video Video subsystem labels May 25, 2025
Copy link

Hello @NinoSc, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with west build -b native_sim/native/64 samples/drivers/video/capture_to_lvgl/ -- -DCONFIG_LV_USE_DROPDOWN=y -DCONFIG_LV_USE_SYSMON=y!

scrot_20250525_180311_965x244

Before that I could not see the statistics anymore on the display.
Maybe there was some change LVGL-side.

Thanks!

@josuah josuah added the area: LVGL Light and Versatile Graphics Library Support label May 25, 2025
@ngphibang
Copy link
Collaborator

Could you fix compliance check ?

CONFIG_LV_USE_PERF_MONITOR depends on CONFIG_LV_USE_SYSMON.

Signed-off-by: Antonino Scarpaci <antonino.scarpaci@gmail.com>
@NinoSc NinoSc force-pushed the fix_capture_to_lvgl_fps branch from 6fe55a2 to 1b0604b Compare May 25, 2025 17:01
Copy link

@kartben kartben merged commit 1508d7e into zephyrproject-rtos:main May 28, 2025
21 checks passed
Copy link

Hi @NinoSc!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LVGL Light and Versatile Graphics Library Support area: Samples Samples area: Video Video subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants