Skip to content

Support StickC-Plus2 #90448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

letanphuc
Copy link

Support StickC-Plus2
https://docs.m5stack.com/en/core/M5StickC%20PLUS2
Anything works well for now.
Uploading image.png…

Build with board name is m5stickc_plus2

Copy link

Hello @letanphuc, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@VynDragon
Copy link
Collaborator

Hello, Thank you.

For supply pin, do not modify the display driver since this is specific to this board, instead, add a CMakelists.txt and relevant code in your board's folder.

@letanphuc letanphuc force-pushed the main branch 2 times, most recently from 355b71a to 3da3203 Compare May 25, 2025 04:02
@letanphuc
Copy link
Author

From my view point, the pin is belong to the display. If we do not use the display, I do not want to turn the pin on anyway.

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@bricle
Copy link
Contributor

bricle commented May 25, 2025

Hello, thank you for your work!
Here are something you need to address, maybe you need to squash your commits into a single one, and force push.
Besides, commit needs a Signed-Off-By so CI will fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants