tests: Bluetooth: Audio: Add common start_broadcast_adv #90434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bsim_start_broadcast_adv
branch
4 times, most recently
from
0b37aa5 to
a1090c5
Compare
github-actions
bot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the logic for starting broadcast advertising in the LE Audio BSIM tests by introducing a common utility function, start_broadcast_adv, to replace duplicated implementations across test files.
- Remove duplicated start_extended_adv functions.
- Update test files (pbp_public_broadcast_source_test.c, gmap_ugg_test.c, and cap_initiator_broadcast_test.c) to invoke the common function.
- Add the declaration in common.h and the implementation in common.c.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bsim/bluetooth/audio/src/pbp_public_broadcast_source_test.c | Replaced start_extended_adv with start_broadcast_adv call |
| tests/bsim/bluetooth/audio/src/gmap_ugg_test.c | Replaced start_extended_adv with start_broadcast_adv call |
| tests/bsim/bluetooth/audio/src/common.h | Added declaration of start_broadcast_adv |
| tests/bsim/bluetooth/audio/src/common.c | Added implementation for start_broadcast_adv |
| tests/bsim/bluetooth/audio/src/cap_initiator_broadcast_test.c | Replaced start_extended_adv with start_broadcast_adv call (multiple sites) |
Comments suppressed due to low confidence (4)
tests/bsim/bluetooth/audio/src/common.c:250
- Consider adding inline documentation for start_broadcast_adv specifying its error handling strategy and its reliance on the FAIL macro, so that future maintainers understand that it does not return error codes.
void start_broadcast_adv(struct bt_le_ext_adv *adv)
tests/bsim/bluetooth/audio/src/pbp_public_broadcast_source_test.c:269
- Replacing start_extended_adv with start_broadcast_adv here is fine as long as the internal error handling (using FAIL) meets the test failure requirements. Please verify that the change does not alter the intended test behavior.
start_broadcast_adv(adv);
tests/bsim/bluetooth/audio/src/gmap_ugg_test.c:1206
- Ensure that replacing start_extended_adv with start_broadcast_adv maintains consistent error handling behavior, as the new function handles errors internally via FAIL without returning an error code.
start_broadcast_adv(adv);
tests/bsim/bluetooth/audio/src/cap_initiator_broadcast_test.c:646
- Since multiple call sites now use start_broadcast_adv instead of start_extended_adv, please ensure that the internal error handling via FAIL meets all test scenarios across this file.
start_broadcast_adv(adv);
larsgk
approved these changes
Jul 1, 2025
Add a common function, start_broadcast_adv, to start broadcast advertisement in the LE Audio BSIM tests. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bsim_start_broadcast_adv
branch
from
a1090c5 to
6553c9b
Compare
|
jthm-ot
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a common function, start_broadcast_adv, to start
broadcast advertisement in the LE Audio BSIM tests.