video: addition of __ASSERT to ensure proper arguments in api functions #90415
+69
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2025 22:17
Protect video API functions via __ASSERT call to ensure that required pointers are valid when entering functions. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Now that video api functions have __ASSERT calls, drivers do not need to check the entry point functions pointers. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
github-actions
bot
added
area: Video
github-actions
bot
requested review from
dbaluta,
decsny,
dleach02,
josuah,
loicpoulain,
LucasTambor,
manuargue,
marekmatej,
mmahadevan108,
ngphibang,
raffarost,
Raymond0225,
sylvioalves,
uLipe and
wmrsouza
|
josuah
approved these changes
May 23, 2025
ngphibang
approved these changes
May 24, 2025
I am been wondering myself as well. Here I think all parameters checked with ASSERT are never expected to have such value, meaning that there is for sure an issue in the application or caller, thus it seemed to be that anyway it doesn't make sense to let the program proceed, hence using ASSERT. |
|
switching the automated assignee to a video collaborator to reduce notification spam |
marekmatej
approved these changes
May 24, 2025
wmrsouza
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the video api function, some functions perform some pointer validation, via if statements or via __ASSERT while some other don't.
Some drivers also performs some pointers validity check (mostly on fmt pointers) while other don't.
In order to try to have something similar for all and avoid drivers having to think about wherher pointer checking is necessary or not, perform those checks within all API functions. Within api ops, drivers can now consider that all pointers are valid.