iar: linker_script: Parse LD style INPUT specifications #90394
Conversation
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
Add support for LD-style file specifications in the IAR generator for `zephyr_linker_section_configure(INPUT` Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
RobinKastberg
force-pushed
the
iar-ld-wildcards
branch
from
a464a4d to
afff1c7
Compare
|
| # <file-pattern>(<section-patterns>... ) | ||
| # <file-pattern> is [library.a:]file | ||
| # e.g. foo.a:bar.o(.data*) | ||
| if(setting MATCHES "^([^\\(]+)\\((.+)\\)$") |
There was a problem hiding this comment.
Shouldnt this be [^\\)]
There was a problem hiding this comment.
Not AFAIK. You want to match anything that is not opening parenthesis and stop when you hit one. This is usually what you mean. and I started doing the non-greedy ones out of habit.
But matching the last parenthesis is not bad anyways. Maybe I will just end up using the regexp you wrote for ld (which I started with, and foolishly thought I could improve).
what do you think about my addition of ^$, could this cause any issues? This is also just regexp habit from my side
I have a hard time seeing filenames/sections with : and ( being well defined. and in that case a more general escaping mechanism would be necessary anyways, and that would probably be much clearly expressed in code, and not a regexp.
There was a problem hiding this comment.
I thought you wanted to match anything upto a closing ) Maybe we just have different greediness habbits ;)
|
@RobinKastberg can you please rebase? |
Add support for LD-style file specifications in the IAR generator for
zephyr_linker_section_configure(INPUT@bjorniuppsala