doc: migration-guide-4.2: video: add note on pitch #90110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngphibang
reviewed
May 18, 2025
doc/releases/migration-guide-4.2.rst
Outdated
| * video_format.pitch is no longer to be set by the application, but instead written back by | ||
| the driver letting the application know how much padding this particular driver will use | ||
| per line and in turn know the required buffer size. Existing applications will not be | ||
| broken by this change but can be simplified as performed in the samplesp in the commit |
There was a problem hiding this comment.
Thank you! I also split an overly long sentence in half in the process.
josuah
force-pushed
the
pr-video-migration-guide
branch
from
d0fc96b to
f9a1ab4
Compare
ngphibang
previously approved these changes
May 18, 2025
josuah
added
Release Notes
dkalowsk
reviewed
May 27, 2025
doc/releases/migration-guide-4.2.rst
Outdated
| the driver. Then the application can know how much padding this particular driver uses | ||
| per line, and in turn know the required buffer size. Existing applications will not be | ||
| broken by this change but can be simplified as performed in the sample in the commit | ||
| ``33dcbe37cfd3593e8c6e9cfd218dd31fdd533598``. |
There was a problem hiding this comment.
A proposed re-wording:
video_format.ptich has been updated to be set explicitly by the driver, a task formerly required of the application.
This update enables the application to correctly allocate a buffer size on a per driver basis. Existing applications
will not be broken by this change but can be simplified as performed in the sample in the commit
``33dcbe37cfd3593e8c6e9cfd218dd31fdd533598``.
There was a problem hiding this comment.
Good to be synthetic and high-level here... Thanks!
josuah
force-pushed
the
pr-video-migration-guide
branch
from
f9a1ab4 to
1491a9e
Compare
|
Force-push:
|
|
Document the change of semantics of video_format.pitch field, modified in commit 33dcbe3. Signed-off-by: Josuah Demangeon <me@josuah.net>
ngphibang
approved these changes
Jun 2, 2025
danieldegrasse
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies:
Document the change of semantics of video_format.pitch field, modified in 33dcbe3
A separate patch to allow it to be discussed separately and speed-up #87366 review.