Skip to content

lib: acpi: Enable poweroff feature #89915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lib: acpi: Enable poweroff feature #89915

wants to merge 2 commits into from

Conversation

akanisetti
Copy link
Contributor

Enable system power-off feature using ACPI by setting platform to S5 state.

Signed-off-by: Anisetti Avinash Krishna anisetti.avinash.krishna@intel.com

@akanisetti akanisetti force-pushed the acpi_based_poweroff branch from 6b2de1a to c422d09 Compare May 14, 2025 05:27
@akanisetti akanisetti marked this pull request as ready for review May 14, 2025 11:15
@github-actions github-actions bot added the area: ACPI ACPI support label May 14, 2025
@github-actions github-actions bot requested a review from najumon1980 May 14, 2025 11:16
@akanisetti akanisetti requested review from andyross and dcpleung June 2, 2025 04:52
pdgendt
pdgendt reviewed Jun 2, 2025
View reviewed changes
@JarmouniA
Copy link
Contributor

Can this be integrated with

zephyr/include/zephyr/sys/poweroff.h

Line 44 in cf6170c

FUNC_NORETURN void sys_poweroff(void);
?

@akanisetti
Copy link
Contributor Author

Can this be integrated with

zephyr/include/zephyr/sys/poweroff.h

Line 44 in cf6170c

FUNC_NORETURN void sys_poweroff(void);

?

Need a shell command, but that option is not there for sys_poweroff so I chose this method.

@akanisetti akanisetti force-pushed the acpi_based_poweroff branch from c422d09 to 89e67af Compare June 2, 2025 09:36
@akanisetti akanisetti requested a review from pdgendt June 2, 2025 09:37
pdgendt
pdgendt reviewed Jun 2, 2025
View reviewed changes
@akanisetti akanisetti force-pushed the acpi_based_poweroff branch from 89e67af to 3b25365 Compare June 2, 2025 09:41
@akanisetti akanisetti requested review from pdgendt and nashif June 3, 2025 02:40
@akanisetti
lib: acpi: Enable poweroff feature
df7f9a4 
Enable system poweroff feature using ACPI.

Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
@akanisetti akanisetti force-pushed the acpi_based_poweroff branch from 3b25365 to df7f9a4 Compare June 26, 2025 03:35
@akanisetti
soc: intel: Added support for sys_poweroff on adl and atom
7da3d33 
Added support for sys_poweroff on ADL and ATOM socs based on
acpi_poweroff.

Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
@github-actions github-actions bot added platform: X86 x86 and x86-64 platform: Intel Intel Corporation labels Jul 15, 2025
@akanisetti akanisetti requested a review from JarmouniA July 15, 2025 15:22
@akanisetti
Copy link
Contributor Author

Can this be integrated with

zephyr/include/zephyr/sys/poweroff.h

Line 44 in cf6170c

FUNC_NORETURN void sys_poweroff(void);

?

Hi @JarmouniA, added support for sys_poweroff based on acpi based poweroff. Please review the changes.

JarmouniA
JarmouniA reviewed Jul 15, 2025
View reviewed changes
@akanisetti akanisetti force-pushed the acpi_based_poweroff branch from b4a6a95 to 7da3d33 Compare July 15, 2025 15:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@akanisetti akanisetti requested a review from JarmouniA July 16, 2025 06:23
@akanisetti
Copy link
Contributor Author

Hi @JarmouniA,
Could you please approve the PR if no further changes?

@JarmouniA
Copy link
Contributor

Hi @JarmouniA, Could you please approve the PR if no further changes?

I'm not very familiar with x86 or ACPI, so my approval won't be of much value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najumon1980 najumon1980 Awaiting requested review from najumon1980

@andyross andyross Awaiting requested review from andyross

@dcpleung dcpleung Awaiting requested review from dcpleung

@pdgendt pdgendt Awaiting requested review from pdgendt

@nashif nashif Awaiting requested review from nashif

@ceolin ceolin Awaiting requested review from ceolin

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@teburd teburd Awaiting requested review from teburd

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

At least 2 approving reviews are required to merge this pull request.

Assignees

@najumon1980 najumon1980

Labels
area: ACPI ACPI support platform: Intel Intel Corporation platform: X86 x86 and x86-64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akanisetti @JarmouniA @pdgendt @najumon1980