-
Notifications
You must be signed in to change notification settings - Fork 7.4k
samples: boards: nxp: s32: create sample mbox #89798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
samples: boards: nxp: s32: create sample mbox #89798
Conversation
6cbc692
to
c6a88c2
Compare
Hello @kartben, Could you please take a look at my PR? Thanks! |
While it's technically possible to send a message from a CPU to itself, that's not a typical or very meaningful use case -especially in the context of a sample. Mailbox peripherals like the MRU are generally intended for inter-CPU communication. This implementation feels more like an internal test case rather than functionality that should be demonstrated in a generic Zephyr sample. |
The sample supports ping-pong loopback data on a MBOX channel within one core. The expected received data must match the sent data when running the sample. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
c6a88c2
to
4cf05d0
Compare
Yes, this implementation is internal and specific to the NXP S32 SoC. Therefore, I created an internal test for the NXP S32 SoC instead of doing in the generic Zephyr test. |
|
By internal I really meant, internal, as not on this Github repo :) I fail to see the benefit of having an NXP sample for the mailbox driver where a CPU send msgs to itself. We could have maybe two Zephyr apps exchanging msgs through the mailbox, it would make more sense. If the mbox maintainers think this is useful, please keep it in the generic sample as you originally did. I can only advise from the NXP S32 pov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @manuargue said, basically. It's really not clear why this new sample would be needed.
The sample supports ping-pong loopback data on a MBOX channel within one core.
The expected received data must match the sent data when running the sample.
The sample result on s32z2xxdc2/s32z270/rtu0: