Skip to content

boards: devicetree: replace 'zephyr,touch' chosen property with the 'touch' DT alias #89752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JarmouniA
Copy link
Collaborator

@JarmouniA JarmouniA commented May 9, 2025

zephyr,touch chosen property is currently used only by the samples/subsys/input/draw_touch_events and not used by any in-tree driver, subsystem, or module.
Hence, it is not justified to keep this chosen property as it only creates confusion and leads users to wrongly assume that setting this property produces some effect in Zephyr internals.

@faxe1008
Copy link
Collaborator

faxe1008 commented May 9, 2025

Hmm not sure about this one. I had in mind to add a feature inside of the gluecode to create a pointer input pseudo device, if a newly added Kconfig symbol LV_Z_POINTER_FROM_CHOSEN is set.

This would allow us to remove the lvgl input pointer from intree dts. As much as I like LVGL (given I am maintaining our fork 🙃) I kinda dislike the fact the device trees contain the pseudo devices by default. In consequence this makes LVGL a non-optional module (kind of) and this feels wrong to me.

@JarmouniA
Copy link
Collaborator Author

I had in mind to add a feature inside of the gluecode to create a pointer input pseudo device, if a newly added Kconfig symbol LV_Z_POINTER_FROM_CHOSEN is set.

Wouldn't that not work for multiple displays? :)

This would allow us to remove the lvgl input pointer from intree dts. As much as I like LVGL (given I am maintaining our fork 🙃) I kinda dislike the fact the device trees contain the pseudo devices by default.

As stated here #86815 (comment), I believe there isn't another practical way around it for the time being.

In consequence this makes LVGL a non-optional module (kind of) and this feels wrong to me.

I agree that's not ideal.

@JarmouniA
Copy link
Collaborator Author

JarmouniA commented May 15, 2025

@kartben @decsny would love to get your thoughts on this.

'zephyr,touch' chosen property is currently used only by the
subsys/input/draw_touch_events sample and not used by any upstream
Zephyr driver, subsystem, or module. Hence it is not justified to have
this chosen property as it only creates confusion and leads users to
wrongly assume that setting this property produces some effect in
Zephyr internals.

Signed-off-by: Abderrahmane JARMOUNI <git@jarmouni.me>
@JarmouniA JarmouniA force-pushed the remove_zephyr_touch_chosen_prop branch from 57e936f to 3e11008 Compare May 24, 2025 19:33
@JarmouniA JarmouniA added the area: Samples Samples label May 24, 2025
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants