LoRa: Initial integration of LoRa Basics Modem for LoRa API & SX126x and SX127x #89241
+1,801
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
avisconti,
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no,
kartben,
Mani-Sadhasivam,
martinjaeger,
marwaiehm-st,
mathieuchopstm,
mniestroj and
nashif
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the LoRa Basics Modem into Zephyr for the LoRa API, providing initial support for the standalone SX126x and SX127x chipsets.
- Added new header file (lbm_common.h) containing common data structures, enums, and function prototypes for modem configuration
- Included an inline helper function for optional GPIO pin configuration
Files not reviewed (11)
- boards/shields/semtech_sx1262mb2das/semtech_sx1262mb2das.overlay: Language not supported
- doc/connectivity/lora_lorawan/index.rst: Language not supported
- drivers/lora/CMakeLists.txt: Language not supported
- drivers/lora/Kconfig: Language not supported
- drivers/lora/lora_basics_modem/CMakeLists.txt: Language not supported
- drivers/lora/lora_basics_modem/Kconfig: Language not supported
- drivers/lora/loramac_node/CMakeLists.txt: Language not supported
- modules/Kconfig: Language not supported
- modules/lora_basics_modem/CMakeLists.txt: Language not supported
- modules/lora_basics_modem/Kconfig: Language not supported
- modules/lora_basics_modem/sx126x.cmake: Language not supported
JordanYates
force-pushed
the
250427_lbm
branch
2 times, most recently
from
70a6e3b to
00580f6
Compare
|
Hi @JordanYates, I'm testing this PR (#89241) on a custom board with an SX1262 for basic LoRa with the send and receive samples. I'm seeing a fatal exception and "LoRa send failed, -22" (EINVAL). This does not happen with loramac-node driver. My Setup:
Relevant Console Logs: Request: |
|
Thanks for taking the time to try it out @mirzasadiqassb. Based on the provided logs, it looks like the TX done interrupt is not being seen by the micro. This is interesting since the logic works on my SX1262 shield. Can you run the test again with the |
|
@JordanYates i will definitely give it a try on this but not during this week, for sure on next week. |
Here is the log when I commented out the
And here is my SX1262 devicetree node: |
My best guess would be a problem related to the external TCXO configuration, which the MBed shield does not have. I should have access to hardware with an external TCXO in the next few weeks, so I can investigate further then. Don't let that dissuade you from digging deeper if you want, I would appreciate any fixes :) |
|
Running some initials tests is indicating that everything is so far so good. Tests have been made on a custom board featuring sx1262. I just forgot to bring another extra board to completely test the tx/rx modes. |
|
Packets are arriving on receiver: |
Move the current implementation of the LoRa API using `loramac-node` to a dedicated folder in preparation for the LoRa basics modem implementation. Signed-off-by: Jordan Yates <jordan@embeint.com>
Import the lora-basics-modem module as an alternate backend for LoRa and LoRaWAN, since loramac-node has been deprecated. Support is currently limited and experimental. Signed-off-by: Jordan Yates <jordan@embeint.com>
|
PR updated with official Zephyr fork: https://github.com/zephyrproject-rtos/lora-basics-modem |
As a first integration of the LoRa Basics Modem backend, implement the LoRa API for the standard SX126x/SX127x chips. Much of the logic from `lbm_common.c` is taken from the loramac-node `sx12xx_common` implementation, but it should now be agnostic for all LoRa RF transceivers. Signed-off-by: Jordan Yates <jordan@embeint.com>
Add testcases for `CONFIG_LORA_MODULE_BACKEND_LORA_BASICS_MODEM` in the LoRa API samples. Signed-off-by: Jordan Yates <jordan@embeint.com>
Document the current status of LoRaMAC-node and LoRa Basics Modem. Signed-off-by: Jordan Yates <jordan@embeint.com>
|
@mirzasadiqassb I have found an issue with the TCXO startup delay handling and pushed a fix, it would be great if you could try again. |
Huh, that's weird. For your reference I am using this board Heltec Wi-Fi Lora32 (V3). When I dig further I found out that my board got stuck during the Here is the log: After further investigation, I found that adding Here’s the log: Also, I’m not sure if this could be related, but could you share your SPI devicetree node just in case? |
Please disregard my original message finding no issue (I deleted it), I did find issues when I tested again (maybe I still had configuration from the loramac-node implementation applied). If you could try with the PR as of my push 10 minutes ago that would be helpful. |
|
|
@JordanYates should this be labeled as "4.2"? |
I did try again with your newest push. However, the problem is still the same as before. Not sure what went wrong. Here is the log: |
That depends on whether we can get enough reviews and resolve the observed issues. |
|
OK, fair, and thanks! |
What check is failing to output the |
Yup I added it inside I notice that this is during the However, DIO1 still never triggered for me: |
github-actions
bot
added
manifest-lora-basics-modem
DNM (manifest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial integration of LoRa Basics Modem (Semtech's replacement for LoRaMAC-node) with Zephyr.
To limit the scope, only the LoRa API is considered, and only the standalone SX126x and SX127x chipsets are ported.
The new drivers use the same devicetree definitions as the current drivers, so the only change required to use the updated drivers is
CONFIG_LORA_MODULE_BACKEND_LORA_BASICS_MODEM=y.Once this PR is merged, we can start to look at:
PR has been tested with the lora send and receive samples between a
semtech_sx1262mb2dasandsemtech_sx1272mb2dasshield in both directions.The SX1262 transmitter, SX1272 receiver setup currently receives packets with ~10dB lower RSSI than the reverse, which I will continue to look into.
Issue for the creation of the module: #89251 (DONE).