drivers: hwinfo: litex: add warning and infos #89240
Conversation
adds warning and info about the LiteX hwinfo driver, that the returned device id is not unique. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
|
|
||
| if (CONFIG_HWINFO_LITEX) | ||
| message(WARNING " | ||
| Warning: CONFIG_HWINFO_LITEX does not return a unique device id. It is shared |
There was a problem hiding this comment.
it's kind of weird to have it as a warning at this level -- there's several other things that this Kconfig being enabled potentially gives access to. In the future the driver might e.g. implement hwinfo_get_reset_cause and at this point warning people who couldn't care less about device ID seems odd.
How about making it a __WARN(...) right in the z_impl_hwinfo_get_device_id of the driver?
| @@ -191,7 +191,9 @@ config HWINFO_LITEX | |||
| depends on DT_HAS_LITEX_DNA0_ENABLED | |||
| select HWINFO_HAS_DRIVER | |||
| help | |||
| Enable LiteX hwinfo driver | |||
| Enable LiteX hwinfo driver. It does not return a unique device id. It is shared | |||
There was a problem hiding this comment.
same remark -- I understand you want to warn people but that KConfig can in theory be for more than just getting device ID. FWIW I think documenting this hardware limitation in the binding might make more sense.
|
IMO this driver is useless, it's only benefit is, that That is the implementation on litex side: It's just a constant with the build time of the litex fpga bitstream. Removal would be the best IMO, due to the following reasons:
@mateusz-holenko you contributed this driver in #18649, can you say why and what was the use-case? |
adds warning and info about the LiteX hwinfo
driver, that the returned device id is not unique.
Signed-off-by: Fin Maaß f.maass@vogl-electronic.com