dts: enum_macros: make sure that they are lowercase #89212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DT_ENUM_HAS_VALUE_BY_IDX states, that the value must be lowercase-and-underscores, this makes sure, that they can match. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
github-actions
bot
added
area: Devicetree
area: Comparator
platform: nRF
github-actions
bot
requested review from
anangl,
bjarki-andreasen,
dbaluta,
decsny,
dleach02,
galak,
jaz1-nordic,
kl-cruz,
magp-nordic,
manuargue,
masz-nordic,
mmahadevan108,
nika-nordic,
Raymond0225 and
rruuaanng
bjarki-andreasen
approved these changes
Apr 28, 2025
|
@dleach02 @mmahadevan108 I saw that in your hal that you are using some *_ENUM_HAS_VALUE with an uppercase value |
rruuaanng
approved these changes
Apr 29, 2025
rruuaanng
approved these changes
Apr 29, 2025
|
@mbolivar ping |
|
re-assigning to active DT collaborators as @mbolivar seems to be AWOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DT_ENUM_HAS_VALUE_BY_IDX states, that the value
must be lowercase-and-underscores, this makes sure,
that they can match.
fixes: #89213